[GitHub] [iceberg] nastra commented on a diff in pull request #7144: Core: Add metrics reporter for serializable table

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7144:
URL: https://github.com/apache/iceberg/pull/7144#discussion_r1141989528


##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -247,6 +252,18 @@ public Map<String, SnapshotRef> refs() {
     return refs;
   }
 
+  @Override
+  public MetricsReporter metricsReporter() {

Review Comment:
   can we add a test that makes sure the metrics reporter is preserved?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org