You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Karel Vervaeke (Created) (JIRA)" <ji...@apache.org> on 2012/02/16 20:54:59 UTC
[jira] [Created] (WHIRR-514) Update release instructions or fix
update-version script?
Update release instructions or fix update-version script?
---------------------------------------------------------
Key: WHIRR-514
URL: https://issues.apache.org/jira/browse/WHIRR-514
Project: Whirr
Issue Type: Task
Components: documentation
Affects Versions: 0.8.0
Reporter: Karel Vervaeke
The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
Updating to version 12345 ...
build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
from build-tools/update-versions:54:in `edit_pom'
from build-tools/update-versions:60:in `process_module'
from build-tools/update-versions:73
from build-tools/update-versions:73:in `each'
from build-tools/update-versions:73
from build-tools/update-versions:54:in `edit_pom'
from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karel Vervaeke updated WHIRR-514:
---------------------------------
Attachment: WHIRR-514-karaf-whirr-version.patch
This patch removes the hard-coded whirr version constant from the java code. Please confirm if you agree to commit this.
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
> Attachments: WHIRR-514-karaf-whirr-version.patch
>
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210154#comment-13210154 ]
Karel Vervaeke commented on WHIRR-514:
--------------------------------------
The update script no longer sets /project/parent/version in the root pom.
In hindsight, the problem with mvn versions:commit (see first comment) was also because the voldemort module is added via a profile, so you can simply do this:
mvn versions:set -DgroupId=org.apache.whirr -DnewVersion=1.2.3
mvn -Pvoldemort versions:commit
This is better than the update script because it doesn't mess with whitespace in the poms. I'll update the release docs to do it this way if nobody minds.
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211826#comment-13211826 ]
Karel Vervaeke commented on WHIRR-514:
--------------------------------------
About being unable to apply the patch: I forgot adding --no-prefix to git diff. Next time I forget, you should try patch -p1 < ....
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
> Attachments: WHIRR-514-karaf-whirr-version.patch
>
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Frank Scholten (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211829#comment-13211829 ]
Frank Scholten commented on WHIRR-514:
--------------------------------------
Also had that problem with git. Run 'git config --global diff.noprefix true' to have git always use the --no-prefix option.
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
> Attachments: WHIRR-514-karaf-whirr-version.patch
>
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Andrei Savu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209690#comment-13209690 ]
Andrei Savu commented on WHIRR-514:
-----------------------------------
BTW we are not actually using the update-versions script when doing the release - I've always done this using bash & sed.
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karel Vervaeke updated WHIRR-514:
---------------------------------
Attachment: WHIRR-514-karaf-whirr-version.patch
The first patch was missing a change
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
> Attachments: WHIRR-514-karaf-whirr-version.patch, WHIRR-514-karaf-whirr-version.patch
>
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209692#comment-13209692 ]
Karel Vervaeke commented on WHIRR-514:
--------------------------------------
I'll have to do this tomorrow. Subversion's driving me nuts.
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211831#comment-13211831 ]
Karel Vervaeke commented on WHIRR-514:
--------------------------------------
Did that, thx. I think this can be closed now.
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
> Fix For: 0.8.0
>
> Attachments: WHIRR-514-karaf-whirr-version.patch
>
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210196#comment-13210196 ]
Karel Vervaeke commented on WHIRR-514:
--------------------------------------
Removed attachments - tests still failing. Sorry for the noise
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Andrei Savu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211561#comment-13211561 ]
Andrei Savu commented on WHIRR-514:
-----------------------------------
+1 (ps. I was unable to apply the patch but it looks good to me)
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
> Attachments: WHIRR-514-karaf-whirr-version.patch
>
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karel Vervaeke resolved WHIRR-514.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.8.0
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
> Fix For: 0.8.0
>
> Attachments: WHIRR-514-karaf-whirr-version.patch
>
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karel Vervaeke updated WHIRR-514:
---------------------------------
Attachment: WHIRR-514-karaf-whirr-version.patch
Here we go again.
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
> Attachments: WHIRR-514-karaf-whirr-version.patch
>
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209678#comment-13209678 ]
Karel Vervaeke commented on WHIRR-514:
--------------------------------------
There's also mvn versions:set and mvn versions:commit, but that has another minor problem which I haven't figured out:
mvn versions:commit doesn't clean up services/zookeeper/pom.xml.versionsBackup.
Anyway fixing update-versions is easy enough. Committing now.
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karel Vervaeke updated WHIRR-514:
---------------------------------
Attachment: (was: WHIRR-514-karaf-whirr-version.patch)
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-514) Update release instructions or fix
update-version script?
Posted by "Karel Vervaeke (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210140#comment-13210140 ]
Karel Vervaeke commented on WHIRR-514:
--------------------------------------
I'm would like to avoid the risk of sed accidentally replacing the version number for dependencies which happen to have the same version number. This is for an automated build system so there's no room for checking by hand every time.
I've updated the script to also include voldemort (It wasn't detected because the module is added via a profile).
Two more problems to solve:
* The version string is present as a String constant in Java code (WhirrKarafTestSupport), I would like to factor that out.
* The update script now sets /project/parent/version for all poms. It should not do this for the root pom.
> Update release instructions or fix update-version script?
> ---------------------------------------------------------
>
> Key: WHIRR-514
> URL: https://issues.apache.org/jira/browse/WHIRR-514
> Project: Whirr
> Issue Type: Task
> Components: documentation
> Affects Versions: 0.8.0
> Reporter: Karel Vervaeke
>
> The update-versions script doesn't handle modules without a /project/parent/version element (the build-tools module doesn't have one).
> karel@tomato:~/work/whirr$ ruby build-tools/update-versions 12345
> Updating to version 12345 ...
> build-tools/update-versions:61:in `process_module': undefined method `inner_html=' for nil:NilClass (NoMethodError)
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:60:in `process_module'
> from build-tools/update-versions:73
> from build-tools/update-versions:73:in `each'
> from build-tools/update-versions:73
> from build-tools/update-versions:54:in `edit_pom'
> from build-tools/update-versions:67
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira