You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2020/03/16 10:21:00 UTC
[jira] [Commented] (PHOENIX-5778) Remove the dependency of
KeyStoreTestUtil
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060097#comment-17060097 ]
Istvan Toth commented on PHOENIX-5778:
--------------------------------------
I don't think that this is a good idea.
We are already deeply tied to HBase and Minicluster, so I wouldn't go down that path. There are other such classes that we use in tests, and IMO replacing them all would decrease, rather than increase maintainability.
Does anyone else have an opinion on this ?
> Remove the dependency of KeyStoreTestUtil
> -----------------------------------------
>
> Key: PHOENIX-5778
> URL: https://issues.apache.org/jira/browse/PHOENIX-5778
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Guanghao Zhang
> Priority: Major
> Fix For: 5.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If I am not wrong, phoenix should reduce the dependency of hbase class/interface which not marked IA.Public. KeyStoreTestUtil is just a static util class. I thought phoenix query server can copy a new one and not depend on hbase's KeyStoreTestUtil.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)