You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2025/07/17 16:18:26 UTC
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23183
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
This patch stops the Hive Metastore until the Iceberg REST Catalog
tests are running. It is needed to verify that Impala is functioning
without the presence of HMS.
Change-Id: I52577501b730e186bd9ee963543796132e42d97b
---
M tests/authorization/test_ranger.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
2 files changed, 48 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/23183/1
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 4: Code-Review+2
I think it is good to go.
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:50:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23183
to look at the new patch set (#2).
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
This patch stops the Hive Metastore until the Iceberg REST Catalog
tests are running. It is needed to verify that Impala is functioning
without the presence of HMS.
Change-Id: I52577501b730e186bd9ee963543796132e42d97b
---
M tests/authorization/test_ranger.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
2 files changed, 94 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/23183/2
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23183
to look at the new patch set (#4).
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
This patch stops the Hive Metastore until the Iceberg REST Catalog
tests are running. It is needed to verify that Impala is functioning
without the presence of HMS.
Change-Id: I52577501b730e186bd9ee963543796132e42d97b
---
M tests/authorization/test_ranger.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
2 files changed, 85 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/23183/4
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
This looks fine to me.
http://gerrit.cloudera.org:8080/#/c/23183/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23183/4//COMMIT_MSG@13
PS4, Line 13: Change-Id: I52577501b730e186bd9ee963543796132e42d97b
nit: mention the test done for this patch.
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:42:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Thanks for the comments, carry +2
http://gerrit.cloudera.org:8080/#/c/23183/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23183/4//COMMIT_MSG@13
PS4, Line 13: Testing
> nit: mention the test done for this patch.
Done
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 13:39:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 4:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12348/
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:31:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12347/
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:17:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12348/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:21:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 19:08:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 1:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py
File tests/custom_cluster/test_iceberg_rest_catalog.py:
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@24
PS1, Line 24: from tests.stress.stress_util import Task, run_tasks
flake8: F401 'tests.stress.stress_util.Task' imported but unused
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@24
PS1, Line 24: from tests.stress.stress_util import Task, run_tasks
flake8: F401 'tests.stress.stress_util.run_tasks' imported but unused
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 16:20:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19901/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 16:45:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 3:
(1 comment)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/23183/3/tests/custom_cluster/test_iceberg_rest_catalog.py
File tests/custom_cluster/test_iceberg_rest_catalog.py:
http://gerrit.cloudera.org:8080/#/c/23183/3/tests/custom_cluster/test_iceberg_rest_catalog.py@51
PS3, Line 51: def init_infra_services(cls):
> Nit: init_infra_services does not need to be its own method. All this code
Done
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jul 2025 17:20:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 18:54:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19939/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 13:31:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12220/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 13:04:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
This patch stops the Hive Metastore until the Iceberg REST Catalog
tests are running. It is needed to verify that Impala is functioning
without the presence of HMS.
Testing
* custom cluster tests and ranger tests updated
Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Reviewed-on: http://gerrit.cloudera.org:8080/23183
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/authorization/test_ranger.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
2 files changed, 85 insertions(+), 33 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19915/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Jul 2025 15:49:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19951/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jul 2025 17:46:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 3: Code-Review+1
(6 comments)
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3284
PS1, Line 3284: cls.iceberg_rest_server.start_rest_server(300)
> Thanks, good idea.
Done
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3285
PS1, Line 3285: except Exception as e:
> Added a check that we don't have HIVE_CONF_DIR set. Manually validated the
Done
http://gerrit.cloudera.org:8080/#/c/23183/3/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/23183/3/tests/authorization/test_ranger.py@3281
PS3, Line 3281: def init_infra_services(cls):
Nit: init_infra_services does not need to be its own method. All this code can go in setup_class.
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py
File tests/custom_cluster/test_iceberg_rest_catalog.py:
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@49
PS1, Line 49:
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@50
PS1, Line 50: @classmethod
> Done
Done
http://gerrit.cloudera.org:8080/#/c/23183/3/tests/custom_cluster/test_iceberg_rest_catalog.py
File tests/custom_cluster/test_iceberg_rest_catalog.py:
http://gerrit.cloudera.org:8080/#/c/23183/3/tests/custom_cluster/test_iceberg_rest_catalog.py@51
PS3, Line 51: def init_infra_services(cls):
Nit: init_infra_services does not need to be its own method. All this code can go in setup_class.
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 20:54:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3284
PS1, Line 3284: self.init_infra_services()
Is it possible to start/stop HMS in the setup_class() and teardown_class() functions? That way, HMS would only have to be stopped/started one time instead of being stopped/started for each test. It doesn't seem to me that is possible without also changing https://github.com/apache/impala/blob/438461db9e82be1d91f4320cce5ab08bc895a305/tests/common/custom_cluster_test_suite.py#L406 as HMS is started in that particular code path.
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3285
PS1, Line 3285: super(TestRangerIcebergRestCatalog, self).setup_method(method)
Looks as if there is a chance HMS could get restarted in CustomClusterTestSuite.setup_method(). That function calls CustomClusterTestSuite.cluster_setup() which has a code path that starts HMS at https://github.com/apache/impala/blob/438461db9e82be1d91f4320cce5ab08bc895a305/tests/common/custom_cluster_test_suite.py#L310
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py
File tests/custom_cluster/test_iceberg_rest_catalog.py:
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@49
PS1, Line 49: self.init_infra_services()
Same as https://gerrit.cloudera.org/c/23183/1/tests/authorization/test_ranger.py#3284
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@50
PS1, Line 50: super(TestIcebergRestCatalog, self).setup_method(method)
Same as https://gerrit.cloudera.org/c/23183/1/tests/authorization/test_ranger.py#3285
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jul 2025 17:18:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 1:
(6 comments)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3284
PS1, Line 3284: self.init_infra_services()
> Is it possible to start/stop HMS in the setup_class() and teardown_class()
Thanks, good idea.
HMS is only started/restarted when HIVE_CONF_DIR is set for the test method. Added a check to setup_method that we don't have HIVE_CONF_DIR specified.
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/authorization/test_ranger.py@3285
PS1, Line 3285: super(TestRangerIcebergRestCatalog, self).setup_method(method)
> Looks as if there is a chance HMS could get restarted in CustomClusterTestS
Added a check that we don't have HIVE_CONF_DIR set. Manually validated the check by trying to set hive_conf_dir the following way:
@CustomClusterTestSuite.with_args(
impalad_args=ICEBERG_REST_IMPALAD_ARGS,
hive_conf_dir='asdf')
def test_rest_catalog_fgac(self, vector):
Also manually checked that HiveMetastore is not running during the tests.
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py
File tests/custom_cluster/test_iceberg_rest_catalog.py:
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@24
PS1, Line 24: from tests.stress.stress_util import Task, run_tasks
> flake8: F401 'tests.stress.stress_util.Task' imported but unused
Done
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@24
PS1, Line 24: from tests.stress.stress_util import Task, run_tasks
> flake8: F401 'tests.stress.stress_util.run_tasks' imported but unused
Done
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@49
PS1, Line 49: self.init_infra_services()
> Same as https://gerrit.cloudera.org/c/23183/1/tests/authorization/test_rang
Done
http://gerrit.cloudera.org:8080/#/c/23183/1/tests/custom_cluster/test_iceberg_rest_catalog.py@50
PS1, Line 50: super(TestIcebergRestCatalog, self).setup_method(method)
> Same as https://gerrit.cloudera.org/c/23183/1/tests/authorization/test_rang
Done
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Jul 2025 15:22:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 2:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/23183/2/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/23183/2/tests/authorization/test_ranger.py@3310
PS2, Line 3310: \
flake8: E502 the backslash is redundant between brackets
http://gerrit.cloudera.org:8080/#/c/23183/2/tests/custom_cluster/test_iceberg_rest_catalog.py
File tests/custom_cluster/test_iceberg_rest_catalog.py:
http://gerrit.cloudera.org:8080/#/c/23183/2/tests/custom_cluster/test_iceberg_rest_catalog.py@73
PS2, Line 73: \
flake8: E502 the backslash is redundant between brackets
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Jul 2025 15:24:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12347/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:07:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23183
to look at the new patch set (#3).
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
This patch stops the Hive Metastore until the Iceberg REST Catalog
tests are running. It is needed to verify that Impala is functioning
without the presence of HMS.
Change-Id: I52577501b730e186bd9ee963543796132e42d97b
---
M tests/authorization/test_ranger.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
2 files changed, 94 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/23183/3
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12358/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 13:40:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20234/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 14:04:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Jason Fehr, Daniel Vanko, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23183
to look at the new patch set (#5).
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
This patch stops the Hive Metastore until the Iceberg REST Catalog
tests are running. It is needed to verify that Impala is functioning
without the presence of HMS.
Testing
* custom cluster tests and ranger tests updated
Change-Id: I52577501b730e186bd9ee963543796132e42d97b
---
M tests/authorization/test_ranger.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
2 files changed, 85 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/23183/5
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23183 )
Change subject: IMPALA-14231: Stop HMS when Iceberg REST Catalog tests are running
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52577501b730e186bd9ee963543796132e42d97b
Gerrit-Change-Number: 23183
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 13:40:23 +0000
Gerrit-HasComments: No