You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/01 13:27:04 UTC

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #1331: make/version: correct the version generation

davids5 commented on a change in pull request #1331:
URL: https://github.com/apache/incubator-nuttx/pull/1331#discussion_r448361873



##########
File path: tools/Makefile.unix
##########
@@ -31,7 +31,7 @@ endif
 
 # In case we cannot get version information from GIT
 
-ifneq ($(GIT_PRESENT),true)
+ifeq ($(GIT_PRESENT),)

Review comment:
       Ok but gist of it is: a .git FILE exist for a submodule. To build out of tree It is copied out of tree.  There it exist as a .git file not in a repo. Then git commands will not work.  There was a bad assumption in the original scripts that .git was a directory.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org