You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Scholte (Jira)" <ji...@apache.org> on 2021/04/20 18:10:00 UTC
[jira] [Closed] (MPLUGIN-360) generated plugin-help.xml ignores
descriptor mojo outputDirectory
[ https://issues.apache.org/jira/browse/MPLUGIN-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed MPLUGIN-360.
----------------------------------
Fix Version/s: 3.6.1
Assignee: Robert Scholte
Resolution: Fixed
Fixed in [e477e6c029be51a41c1b20ebfb2980dfa5c38b56|https://gitbox.apache.org/repos/asf?p=maven-plugin-tools.git;a=commit;h=e477e6c029be51a41c1b20ebfb2980dfa5c38b56]
The code in now consistent. I've also decided to mark the outputDirectory to read-only, otherwise the plugin configuration be recognized by Maven, and would the HelpMojo not work (because it couldn't find the descriptor).
> generated plugin-help.xml ignores descriptor mojo outputDirectory
> -----------------------------------------------------------------
>
> Key: MPLUGIN-360
> URL: https://issues.apache.org/jira/browse/MPLUGIN-360
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
> Affects Versions: 3.6.0
> Reporter: Dariusz Kuc
> Assignee: Robert Scholte
> Priority: Minor
> Fix For: 3.6.1
>
>
> _maven-plugin-plugin:descriptor_ mojo supports specifying custom output directory ([https://maven.apache.org/components/plugin-tools-archives/plugin-tools-3.5/maven-plugin-plugin/descriptor-mojo.html#outputDirectory]) but it is only used for generation of *_plugin.xml_*, *_* _*_plugin-help.xml*_ is always generated under default build directory.
>
> In code:
> * plugin.xml uses correct directory -> [[https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java#L77]
> {code:java}
> File f = new File( destinationDirectory, "plugin.xml" );{code}
> * plugin-help.xml uses default build directory -> [https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java#L83]
> {code:java}
> f = new File( mavenProject.getBuild().getOutputDirectory(), PluginHelpGenerator.getPluginHelpPath( mavenProject ) );{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)