You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/04 16:10:17 UTC

[GitHub] [airflow] kaxil edited a comment on pull request #10150: Do not use .format() in log messages

kaxil edited a comment on pull request #10150:
URL: https://github.com/apache/airflow/pull/10150#issuecomment-668686698


   > Would it make sense to add a pre-commit hook for something like this? Would it be possible with `py-grep`?
   
   Actually Pylint takes care of this, currently this files are ignored in pylint-todo:
   
   https://github.com/apache/airflow/blob/1bca31b541c9c39fb8e79131e1dd4a868b5122d4/scripts/ci/pylint_todo.txt#L4-L5
   
   and hence Pylint didn't catch it 😬 
   
   The Pylint check that takes care of it is `logging-format-interpolation (W1202)` and `logging-not-lazy (W1201):`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org