Re: Review Request: CAS-CL move to trunk

[Chris Mattmann <ma...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2638/#review2976
-----------------------------------------------------------

Ship it!


Hey Brian, I see 4 files that shouldn't be there:

https://svn.apache.org/repos/asf/oodt/trunk/cli/.classpath: 1 change [ new content ]
https://svn.apache.org/repos/asf/oodt/trunk/cli/.project: 1 change [ new content ]
https://svn.apache.org/repos/asf/oodt/trunk/cli/move_cas-cl_to_trunk-update.patch.txt: 1 change [ new content ]
https://svn.apache.org/repos/asf/oodt/trunk/cli/move_cas-cl_to_trunk.patch.txt: 1 change [ new content ]

But you did take care of my other 2 requests, thanks! 

If you remove those 4 files from the patch, I'm +1 to SHIP IT.

- Chris


On 2011-10-31 22:26:03, brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2638/
> -----------------------------------------------------------
> 
> (Updated 2011-10-31 22:26:03)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Summary
> -------
> 
> CAS-CL will be initally just moved to trunk, then will be added to components 1 by 1 after that
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/.classpath PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/.project PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/.settings/org.eclipse.jdt.core.prefs PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/move_cas-cl_to_trunk-update.patch.txt PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/move_cas-cl_to_trunk.patch.txt PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/pom.xml PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/CmdLineArgs.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/CmdLineUtility.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/CmdLineAction.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/PrintMessageAction.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/store/CmdLineActionStore.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/store/CmdLineActionStoreFactory.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/store/spring/SpringCmdLineActionStore.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/store/spring/SpringCmdLineActionStoreFactory.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/action/store/spring/SpringSetContextInjectionType.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/help/OptionHelpException.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/help/presenter/CmdLineOptionHelpPresenter.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/help/presenter/StdCmdLineOptionHelpPresenter.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/help/printer/CmdLineActionHelpPrinter.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/help/printer/CmdLineActionsHelpPrinter.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/help/printer/CmdLineOptionsHelpPrinter.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/help/printer/StdCmdLineActionHelpPrinter.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/help/printer/StdCmdLineActionsHelpPrinter.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/help/printer/StdCmdLineOptionsHelpPrinter.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/ActionCmdLineOption.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/AdvancedCmdLineOption.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/CmdLineOption.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/CmdLineOptionInstance.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/GroupCmdLineOption.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/HandleableCmdLineOption.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/HelpCmdLineOption.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/PrintSupportedActionsCmdLineOption.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/SimpleCmdLineOption.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/ValidatableCmdLineOption.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/handler/ApplyToAction.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/handler/ApplyToActionHandler.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/handler/CmdLineOptionHandler.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/handler/SetJavaPropertiesHandler.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/require/ActionDependencyRule.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/require/RequirementRule.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/store/CmdLineOptionStore.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/store/CmdLineOptionStoreFactory.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/store/spring/SpringCmdLineOptionStore.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/store/spring/SpringCmdLineOptionStoreFactory.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/validator/AllowedArgsCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/validator/ArgRegExpCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/validator/ClassExistsCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/validator/CmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/validator/FileExistCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/option/validator/NoRestrictionsCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/parser/CmdLineOptionParser.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/parser/StdCmdLineOptionParser.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/util/Args.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/main/java/org/apache/oodt/cas/cli/util/CmdLineUtils.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/TestCmdLineArgs.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/TestCmdLineUtility.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/action/store/spring/TestSpringCmdLineActionStore.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/handler/TestApplyToAction.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/handler/TestApplyToActionHandler.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/handler/TestSetJavaPropertiesHandler.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/require/TestActionDependencyRule.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/store/spring/TestSpringCmdLineOptionStore.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/validator/TestAllowedArgsCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/validator/TestArgRegExpCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/validator/TestClassExistsCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/validator/TestFileExistCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/option/validator/TestNoRestrictionsCmdLineOptionValidator.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/parser/TestStdCmdLineOptionParser.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestOutputStream.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestSetContextInjectTypeAction.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/test/util/TestUtils.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/util/TestArgs.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/test/org/apache/oodt/cas/cli/util/TestCmdLineUtils.java PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/testdata/cmd-line-actions.xml PRE-CREATION 
>   https://svn.apache.org/repos/asf/oodt/trunk/cli/src/testdata/cmd-line-options.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/2638/diff
> 
> 
> Testing
> -------
> 
> Many unit-tests
> 
> 
> Thanks,
> 
> brian
> 
>