You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/09/01 03:24:19 UTC
[kudu-CR] [threadpool] Fix a coredump when shutdown SchedulerThread
Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18867
to look at the new patch set (#9).
Change subject: [threadpool] Fix a coredump when shutdown SchedulerThread
......................................................................
[threadpool] Fix a coredump when shutdown SchedulerThread
When shutdown thread pool with SchedulerThread,
thread pool's variable 'scheduler_' is deleted
and 'scheduler_' = nullptr, at the same time,
thread pool token not shutdowned and schedule a
task, this may cause a coredump because of
'scheduler_' = nullptr.
This patch add a mutex lock in class
'ThreadPool' to protect variable 'scheduler_'.
Change-Id: I021422f7e51e1007c5bdbc877ab445f70ba12357
---
M src/kudu/util/threadpool-test.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
3 files changed, 60 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/18867/9
--
To view, visit http://gerrit.cloudera.org:8080/18867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I021422f7e51e1007c5bdbc877ab445f70ba12357
Gerrit-Change-Number: 18867
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>