You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Steven Yates <sy...@stevendyates.com> on 2014/02/05 13:13:30 UTC
Review Request 17741: SAMZA-116
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17741/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-116
https://issues.apache.org/jira/browse/SAMZA-116
Repository: samza
Description
-------
A quick patch for Samza-116
Diffs
-----
samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 89730db
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 56ec964
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala bcd8998
Diff: https://reviews.apache.org/r/17741/diff/
Testing
-------
Thanks,
Steven Yates
Re: Review Request 17741: SAMZA-116
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17741/#review33805
-----------------------------------------------------------
Ship it!
Ship It!
- Chris Riccomini
On Feb. 6, 2014, 12:35 p.m., Steven Yates wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17741/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2014, 12:35 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-116
> https://issues.apache.org/jira/browse/SAMZA-116
>
>
> Repository: samza
>
>
> Description
> -------
>
> A quick patch for Samza-116
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 89730db
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 56ec964
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala bcd8998
>
> Diff: https://reviews.apache.org/r/17741/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steven Yates
>
>
Re: Review Request 17741: SAMZA-116
Posted by Steven Yates <sy...@stevendyates.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17741/
-----------------------------------------------------------
(Updated Feb. 6, 2014, 12:35 p.m.)
Review request for samza.
Bugs: SAMZA-116
https://issues.apache.org/jira/browse/SAMZA-116
Repository: samza
Description
-------
A quick patch for Samza-116
Diffs (updated)
-----
samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 89730db
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 56ec964
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala bcd8998
Diff: https://reviews.apache.org/r/17741/diff/
Testing
-------
Thanks,
Steven Yates
Re: Review Request 17741: SAMZA-116
Posted by Steven Yates <sy...@stevendyates.com>.
> On Feb. 5, 2014, 6:57 p.m., Chris Riccomini wrote:
> > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala, line 121
> > <https://reviews.apache.org/r/17741/diff/1/?file=470036#file470036line121>
> >
> > You don't need the {} here, right?
nope, removed and diff updated. Thanks Chris
- Steven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17741/#review33704
-----------------------------------------------------------
On Feb. 5, 2014, 12:13 p.m., Steven Yates wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17741/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2014, 12:13 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-116
> https://issues.apache.org/jira/browse/SAMZA-116
>
>
> Repository: samza
>
>
> Description
> -------
>
> A quick patch for Samza-116
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 89730db
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 56ec964
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala bcd8998
>
> Diff: https://reviews.apache.org/r/17741/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steven Yates
>
>
Re: Review Request 17741: SAMZA-116
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17741/#review33704
-----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala
<https://reviews.apache.org/r/17741/#comment63302>
You don't need the {} here, right?
- Chris Riccomini
On Feb. 5, 2014, 12:13 p.m., Steven Yates wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17741/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2014, 12:13 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-116
> https://issues.apache.org/jira/browse/SAMZA-116
>
>
> Repository: samza
>
>
> Description
> -------
>
> A quick patch for Samza-116
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 89730db
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala 56ec964
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala bcd8998
>
> Diff: https://reviews.apache.org/r/17741/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steven Yates
>
>