You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Stefan (JIRA)" <ji...@apache.org> on 2009/01/30 14:53:59 UTC
[jira] Created: (WICKET-2062) Wicket-autocomplete.js should call
wicketHide and wicketShow
Wicket-autocomplete.js should call wicketHide and wicketShow
------------------------------------------------------------
Key: WICKET-2062
URL: https://issues.apache.org/jira/browse/WICKET-2062
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.3.5
Reporter: Stefan
wicket-autocomplete.js functions showIndicator() and hideIndicator should call wicketHide(..) and wicketShow(..) functions instead of method below.
function showIndicator() {
if (indicatorId!=null) {
Wicket.$(indicatorId).style.display=''; }
}
function hideIndicator() {
if (indicatorId!=null) {
Wicket.$(indicatorId).style.display='none';
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2062) Wicket-autocomplete.js should call
wicketHide and wicketShow
Posted by "Stefan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669009#action_12669009 ]
Stefan commented on WICKET-2062:
--------------------------------
Those functions are part of the file wicket-ajax.js so I assume that those functions should be used as well. Currently we are overriding the wicketShow and wicketHide functions in our application.
> Wicket-autocomplete.js should call wicketHide and wicketShow
> ------------------------------------------------------------
>
> Key: WICKET-2062
> URL: https://issues.apache.org/jira/browse/WICKET-2062
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5
> Reporter: Stefan
>
> wicket-autocomplete.js functions showIndicator() and hideIndicator should call wicketHide(..) and wicketShow(..) functions instead of method below.
> function showIndicator() {
> if (indicatorId!=null) {
> Wicket.$(indicatorId).style.display=''; }
> }
>
> function hideIndicator() {
> if (indicatorId!=null) {
> Wicket.$(indicatorId).style.display='none';
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2062) Wicket-autocomplete.js should call
wicketHide and wicketShow
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668933#action_12668933 ]
Igor Vaynberg commented on WICKET-2062:
---------------------------------------
why is this a bug? does something not work properly?
> Wicket-autocomplete.js should call wicketHide and wicketShow
> ------------------------------------------------------------
>
> Key: WICKET-2062
> URL: https://issues.apache.org/jira/browse/WICKET-2062
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5
> Reporter: Stefan
>
> wicket-autocomplete.js functions showIndicator() and hideIndicator should call wicketHide(..) and wicketShow(..) functions instead of method below.
> function showIndicator() {
> if (indicatorId!=null) {
> Wicket.$(indicatorId).style.display=''; }
> }
>
> function hideIndicator() {
> if (indicatorId!=null) {
> Wicket.$(indicatorId).style.display='none';
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2062) Wicket-autocomplete.js should call
wicketHide and wicketShow
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2062:
----------------------------------
Issue Type: Wish (was: Bug)
thats what i thought, you should not be overriding any wicket javascript functions. all of that javascript is completely internal, once you do you are on your own.
> Wicket-autocomplete.js should call wicketHide and wicketShow
> ------------------------------------------------------------
>
> Key: WICKET-2062
> URL: https://issues.apache.org/jira/browse/WICKET-2062
> Project: Wicket
> Issue Type: Wish
> Components: wicket-extensions
> Affects Versions: 1.3.5
> Reporter: Stefan
>
> wicket-autocomplete.js functions showIndicator() and hideIndicator should call wicketHide(..) and wicketShow(..) functions instead of method below.
> function showIndicator() {
> if (indicatorId!=null) {
> Wicket.$(indicatorId).style.display=''; }
> }
>
> function hideIndicator() {
> if (indicatorId!=null) {
> Wicket.$(indicatorId).style.display='none';
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2062) Wicket-autocomplete.js should call
wicketHide and wicketShow
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2062.
-----------------------------------
Resolution: Won't Fix
Assignee: Igor Vaynberg
if you still need this please request appropriate plugin points to be exposed on the autocomplete widget.
> Wicket-autocomplete.js should call wicketHide and wicketShow
> ------------------------------------------------------------
>
> Key: WICKET-2062
> URL: https://issues.apache.org/jira/browse/WICKET-2062
> Project: Wicket
> Issue Type: Wish
> Components: wicket-extensions
> Affects Versions: 1.3.5
> Reporter: Stefan
> Assignee: Igor Vaynberg
>
> wicket-autocomplete.js functions showIndicator() and hideIndicator should call wicketHide(..) and wicketShow(..) functions instead of method below.
> function showIndicator() {
> if (indicatorId!=null) {
> Wicket.$(indicatorId).style.display=''; }
> }
>
> function hideIndicator() {
> if (indicatorId!=null) {
> Wicket.$(indicatorId).style.display='none';
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.