You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by ov...@apache.org on 2021/04/20 10:29:38 UTC

[echarts-bot] branch master updated: feat: add zr daily build

This is an automated email from the ASF dual-hosted git repository.

ovilia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts-bot.git


The following commit(s) were added to refs/heads/master by this push:
     new 6590f30  feat: add zr daily build
6590f30 is described below

commit 6590f3015eacc1f8ffc85fd88618a26a0e9e6b62
Author: Ovilia <zw...@gmail.com>
AuthorDate: Tue Apr 20 18:29:28 2021 +0800

    feat: add zr daily build
---
 index.js    | 7 +++++--
 src/text.js | 5 ++++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/index.js b/index.js
index c368901..010fdc6 100644
--- a/index.js
+++ b/index.js
@@ -125,10 +125,13 @@ module.exports = (app) => {
         }
 
         const content = context.payload.pull_request.body;
-        if (content && content.indexOf('[x] The API has been changed.') > -1) {
+        if (content && content.indexOf('[x] The API has been changed') > -1) {
             labelList.push('PR: awaiting doc');
             commentText += '\n\n' + text.PR_AWAITING_DOC;
         }
+        if (content && content.indexOf('[x] This PR depends on ZRender changes') > -1) {
+            commentText += '\n\n' + text.PR_ZRENDER_CHANGED;
+        }
 
         if (await isFirstTimeContributor(context)) {
             labelList.push('PR: first-time contributor');
@@ -173,7 +176,7 @@ module.exports = (app) => {
         }
 
         const content = context.payload.pull_request.body;
-        if (content && content.indexOf('[x] The API has been changed.') > -1) {
+        if (content && content.indexOf('[x] The API has been changed') > -1) {
             addLabels.push('PR: awaiting doc');
         }
         else {
diff --git a/src/text.js b/src/text.js
index c2651ee..b955a3e 100644
--- a/src/text.js
+++ b/src/text.js
@@ -53,7 +53,9 @@ const PR_OPENED_BY_COMMITTER = PR_OPENED + `
 
 The pull request is marked to be \`PR: author is committer\` because you are a committer of this project.`;
 
-const PR_AWAITING_DOC = `Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes. When the doc PR is merged, the maintainers will remove the \`PR: awaiting doc\` label.`;
+const PR_AWAITING_DOC = `Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the \`PR: awaiting doc\` label.`;
+
+const PR_ZRENDER_CHANGED = 'This PR depends on [ZRender](https://github.com/ecomfe/zrender) changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time).\nYou can use `npm i zrender@npm:zrender-nightly@dev` to update package.json.\nIf you have any question about this, please leave a comment and we will give you extra help on this.';
 
 const PR_MERGED =
     `Congratulations! Your PR has been merged. Thanks for your contribution! 👍`;
@@ -90,6 +92,7 @@ module.exports = {
     PR_OPENED_BY_COMMITTER,
     PR_NOT_MERGED,
     PR_AWAITING_DOC,
+    PR_ZRENDER_CHANGED,
     ISSUE_TAGGED_WAITING_AUTHOR,
     ISSUE_TAGGED_EASY,
     ISSUE_TAGGED_PRIORITY_HIGH,

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org