You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/08/23 03:53:54 UTC

[GitHub] [incubator-hugegraph] simon824 opened a new pull request, #1953: chore: fix GraphOfTheMoviesExample Exception

simon824 opened a new pull request, #1953:
URL: https://github.com/apache/incubator-hugegraph/pull/1953

   This pr will fix these exception:
   ```
   Exception in thread "main" java.lang.IllegalArgumentException: No need to build index on properties [name], because they contains all primary keys [name] for vertex label 'person'
   ```
   
   ```
   Exception in thread "main" java.lang.IllegalStateException: Stop the current transaction before opening another
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1953: chore: fix GraphOfTheMoviesExample Exception

Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1953:
URL: https://github.com/apache/incubator-hugegraph/pull/1953#discussion_r952212297


##########
hugegraph-example/src/main/java/com/baidu/hugegraph/example/GraphOfTheMoviesExample.java:
##########
@@ -105,13 +105,9 @@ public static void load(final HugeGraph graph) {
               .sourceLabel("person").targetLabel("movie")
               .create();
 
-        schema.indexLabel("personByName").onV("person").by("name")

Review Comment:
   THX, could add & run it in test/CI?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-hugegraph] imbajin merged pull request #1953: chore: fix GraphOfTheMoviesExample exception

Posted by GitBox <gi...@apache.org>.
imbajin merged PR #1953:
URL: https://github.com/apache/incubator-hugegraph/pull/1953


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1953: chore: fix GraphOfTheMoviesExample Exception

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1953:
URL: https://github.com/apache/incubator-hugegraph/pull/1953#issuecomment-1223506246

   # [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1953](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c2eec19) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/5172f773a8e7ec6811423c67bd83105c3e73ae83?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5172f77) will **decrease** coverage by `21.51%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #1953       +/-   ##
   =============================================
   - Coverage     70.48%   48.97%   -21.52%     
   + Complexity      978      651      -327     
   =============================================
     Files           452      452               
     Lines         38990    38990               
     Branches       5554     5554               
   =============================================
   - Hits          27482    19095     -8387     
   - Misses         8809    17862     +9053     
   + Partials       2699     2033      -666     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...du/hugegraph/util/FixedWatchWindowRateLimiter.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3V0aWwvRml4ZWRXYXRjaFdpbmRvd1JhdGVMaW1pdGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...du/hugegraph/backend/store/mysql/MysqlMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLW15c3FsL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL215c3FsL015c3FsTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hugegraph/backend/store/raft/RaftStoreClosure.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9SYWZ0U3RvcmVDbG9zdXJlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hugegraph/job/schema/OlapPropertyKeyCreateJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2pvYi9zY2hlbWEvT2xhcFByb3BlcnR5S2V5Q3JlYXRlSm9iLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...hugegraph/job/schema/OlapPropertyKeyRemoveJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2pvYi9zY2hlbWEvT2xhcFByb3BlcnR5S2V5UmVtb3ZlSm9iLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ugegraph/backend/store/memory/InMemoryMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvbWVtb3J5L0luTWVtb3J5TWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...egraph/backend/store/hbase/HbaseStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWhiYXNlL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL2hiYXNlL0hiYXNlU3RvcmVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...egraph/backend/store/scylladb/ScyllaDBMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...graph/backend/store/scylladb/ScyllaDBFeatures.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCRmVhdHVyZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ackend/store/cassandra/CassandraStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNhc3NhbmRyYS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYmFja2VuZC9zdG9yZS9jYXNzYW5kcmEvQ2Fzc2FuZHJhU3RvcmVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [180 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1953/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org