You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org> on 2005/11/28 09:19:40 UTC
[jira] Created: (MYFACES-881) TLD tranformations break build
TLD tranformations break build
------------------------------
Key: MYFACES-881
URL: http://issues.apache.org/jira/browse/MYFACES-881
Project: MyFaces
Type: Bug
Components: General
Versions: Nightly
Environment: checkout from nov. 26 - problem persists after update on nov. 27
Reporter: Dennis Byrne
Priority: Critical
There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-881) TLD tranformations break build
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=comments#action_12358884 ]
Dennis Byrne commented on MYFACES-881:
--------------------------------------
Thanks. Trunk builds fine for me now.
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: align_singular.txt, impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-881) TLD tranformations break build
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=comments#action_12358736 ]
Simon Kitching commented on MYFACES-881:
----------------------------------------
Hi Dennis,
I've committed your provided patches. As I am still unable to figure out how to persuade Ant to provide me with error messages like you get, can you please update and build to verify that everything is ok?
By the way, what OS, Ant version, java version, etc. are you using? I'd really like to figure out how to enable these error messages!
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-881) TLD tranformations break build
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=comments#action_12358750 ]
Dennis Byrne commented on MYFACES-881:
--------------------------------------
At this point I think it's important to say that Simon and Steve are part of the solution and not the problem.
Make sure you guys aren't getting the errors because you have had *previously* successful builds. The *output* of those builds is preventing the errors. Try it on a fresh checkout, or run 'dist-all' after 'clean-all'.
For example, after a successful build, and placing '&derek_zoolander;' in one of the TLD fragments under impl, I don't get errors when running 'dist-all'. That's because of the following (ant w/ -debug during 'tlddoc'). Note the .tld inclusions at the bottom.
fileset: Setup scanner in dir D:\npeUpdateActionListener\current\impl\build\temp\tlds with patternSet{ includes: [] excludes: [myfaces_ext.tld] }
[apply] Executing 'java' with arguments:
[apply] '-jar'
[apply] 'D:\npeUpdateActionListener\current\build/../lib/tlddoc.jar'
[apply] '-doctitle'
[apply] 'Tag library for Apache MyFaces'
[apply] '-xslt'
[apply] 'D:\npeUpdateActionListener\current\build\tlddoc-xslt'
[apply] '-d'
[apply] 'D:\npeUpdateActionListener\current\build/../impl/build/temp/tlddoc'
[apply] 'D:\npeUpdateActionListener\current\impl\build\temp\tlds\myfaces_core.tld'
[apply] 'D:\npeUpdateActionListener\current\impl\build\temp\tlds\myfaces_html.tld'
If current\impl\build\temp\tlds\myfaces_html.tld is deleted, a subsequent 'dist-all' will blow up.
This is a build issue. It's not my call, but I suggest reorganizing build.xml before this one is closed. Someone needs look at the nightly builds and the tests too. There will only be more situations where people like Steve and Simon end up working with a false sense of accuracy in their work.
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-881) TLD tranformations break build
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=all ]
Dennis Byrne updated MYFACES-881:
---------------------------------
Attachment: align_singular.txt
BTW, trunk builds fine for me if I apply this one-liner for the align attribute.
ant version 1.6.3 / java version 1.4.2 / WinXP / Eclipse 3.1.0
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: align_singular.txt, impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-881) TLD tranformations break build
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=comments#action_12358626 ]
Dennis Byrne commented on MYFACES-881:
--------------------------------------
That's a good question. My build.xml is straight from trunk and run from w/in eclipse 3.1. It's running in a 1.4 jvm w/ everything under /current/lib in the classpath . Also, this is w/ "dist-all" .
Thanks for at least confirming there were some errors - but what stumps me is the fact that there are plenty of nightly builds for the past couple of days. If you have time, try pulling trunk and see if you get a bunch of these:
javax.xml.transform.TransformerException: Reference to undefined entity "&html_focusblur_attribute;"
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-881) TLD tranformations break build
Posted by "Dennis Byrne (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=all ]
Dennis Byrne updated MYFACES-881:
---------------------------------
Attachment: impl.tld.nov.26.05.txt
tomahawk.tld.nov.26.05.txt
sandbox.tld.nov.26.05.txt
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-881) TLD tranformations break build
Posted by "sean schofield (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=comments#action_12358740 ]
sean schofield commented on MYFACES-881:
----------------------------------------
@Simon, I have the same issue (or lack of issue) as you have.
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-881) TLD tranformations break build
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=comments#action_12358624 ]
Simon Kitching commented on MYFACES-881:
----------------------------------------
Thanks for the patchfiles Dennis; they do look like errors; I'll apply these patches in about 12 hours from now...
However I'm puzzled about why you're getting errors reported. I'm not getting any error output from a build, either on my work machine or my home one.
Obviously neither is Steve Peterson.
And the TLD + doc files are getting generated for me (possibly with the problem attributes missing (focus/blur on textarea, disabled on radiobutton etc)).
Do you have some special settings in build.properties or something to make the Java XML parser report these errors?
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-881) TLD tranformations break build
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=all ]
Simon Kitching closed MYFACES-881:
----------------------------------
Resolution: Fixed
Many thanks to Dennis for reporting this issue and providing patches.
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: align_singular.txt, impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-881) TLD tranformations break build
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=comments#action_12358836 ]
Simon Kitching commented on MYFACES-881:
----------------------------------------
Thanks Dennis; fix to sandbox tld is applied. If you can just confirm that this is all ok I will close this issue.
Re the error messages, the problem is *not* a dirty build directory. I've managed to duplicate it with a very simple example, and have posted this to the ant list:
http://marc.theaimsgroup.com/?t=113321944700003&r=1&w=2
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: align_singular.txt, impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-881) TLD tranformations break build
Posted by "Steve Peterson (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-881?page=comments#action_12358653 ]
Steve Peterson commented on MYFACES-881:
----------------------------------------
Simon is right that I wasn't seeing any build errors. I'm on XP SP2 with JDK 1.4.2_09.
I reviewed Dennis' patch and it looks correct. Note that this patch should be applied before the inposted changes on MYFACES-866.
> TLD tranformations break build
> ------------------------------
>
> Key: MYFACES-881
> URL: http://issues.apache.org/jira/browse/MYFACES-881
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Environment: checkout from nov. 26 - problem persists after update on nov. 27
> Reporter: Dennis Byrne
> Priority: Critical
> Attachments: impl.tld.nov.26.05.txt, sandbox.tld.nov.26.05.txt, tomahawk.tld.nov.26.05.txt
>
> There are about 20 transformation errors that occur in the build process. This affects the TLDs for impl, tomahawk and the sandbox.
> The following patches stop the build errors. The tests still need to be run.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira