You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by ke...@apache.org on 2008/05/27 10:51:59 UTC

svn commit: r660432 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java

Author: keithc
Date: Tue May 27 01:51:59 2008
New Revision: 660432

URL: http://svn.apache.org/viewvc?rev=660432&view=rev
Log:
Fixing Axis2-3819. WSDJ4J had two methods to get the parts of a message one returns a map while the other returns a List. We should have been using the List in this case to ensure that we retrieve 
the parts in order


Modified:
    webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java

Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java?rev=660432&r1=660431&r2=660432&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java Tue May 27 01:51:59 2008
@@ -1578,12 +1578,8 @@
                 if (BINDING_TYPE_SOAP.equals(this.bindingType)) {
                     // first see the body parts list
                     List bodyPartsList =
-                            getPartsListFromSoapBody(bindingInput.getExtensibilityElements());
-                    if (bodyPartsList != null) {
-                        partsCollection = message.getOrderedParts(bodyPartsList);
-                    } else {
-                        partsCollection = message.getParts().values();
-                    }
+                        getPartsListFromSoapBody(bindingInput.getExtensibilityElements());
+                    partsCollection = message.getOrderedParts(bodyPartsList);
                 } else {
                     // i.e http binding
                     partsCollection = message.getParts().values();
@@ -1668,13 +1664,9 @@
                 if (BINDING_TYPE_SOAP.equals(this.bindingType)) {
                     // first see the body parts list
                     List bodyPartsList =
-                            getPartsListFromSoapBody(bindingOutput.getExtensibilityElements());
-                    if (bodyPartsList != null) {
-                        partsCollection = message.getOrderedParts(bodyPartsList);
-                    } else {
-                        // then see the parameter order
-                        partsCollection = message.getParts().values();
-                    }
+                        getPartsListFromSoapBody(bindingOutput.getExtensibilityElements());
+                    partsCollection = message.getOrderedParts(bodyPartsList);
+
                 } else {
                     // i.e if http binding
                     partsCollection = message.getParts().values();