[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #433: [ISSUE #367] Refactor connector

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #433:
URL: https://github.com/apache/incubator-eventmesh/pull/433#discussion_r670943747



##########
File path: eventmesh-starter/build.gradle
##########
@@ -16,7 +16,7 @@
  */
 
 dependencies {
-    implementation project(":eventmesh-runtime"), project(":eventmesh-connector-rocketmq")
-    testImplementation project(":eventmesh-runtime"), project(":eventmesh-connector-rocketmq")
+    implementation project(":eventmesh-runtime")

Review comment:
       Yes, if the starter module is only used to package dependencies, we can remove this module, but not sure if other things will need to be done in the future before runtime starting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org