You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by PascalSchumacher <gi...@git.apache.org> on 2016/10/23 17:57:24 UTC
[GitHub] commons-lang pull request #202: LANG-1034: Recursive and reflective EqualsBu...
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/202
LANG-1034: Recursive and reflective EqualsBuilder
patch by yathos UG
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang recursiveAndReflectiveEqualsBuilder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/202.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #202
----
commit b6eee76036d4e44f89f029aa3d45b6842598e69b
Author: pascalschumacher <pa...@gmx.net>
Date: 2016-10-23T17:56:28Z
LANG-1034: Recursive and reflective EqualsBuilder
patch by yathos UG
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Posted by douddle <gi...@git.apache.org>.
Github user douddle commented on the issue:
https://github.com/apache/commons-lang/pull/202
I start to use your feature and I discover a bug.
String are now compared with internal data (hash and char[]). But sometimes hash value is not initialized, this is probably a cache for the hashcode. So the comparison fails even if the char[] content is the same.
---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/202
[](https://coveralls.io/builds/8691417)
Coverage decreased (-0.007%) to 93.555% when pulling **2d6ce6ad6a1575c13da903e233bf21a0421f5352 on PascalSchumacher:recursiveAndReflectiveEqualsBuilder** into **05647d46e9ac2bf674b320e8467616aa72954f3e on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/202
I haven't locked at this in-depth yet, but seems like a useful enhancement.
I would remove the support for including transient fields, because that seems like a bad practice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/202
[](https://coveralls.io/builds/8692844)
Coverage decreased (-0.02%) to 93.542% when pulling **b8c733670847731c4108aecc6ae4b433e042fbcb on PascalSchumacher:recursiveAndReflectiveEqualsBuilder** into **05647d46e9ac2bf674b320e8467616aa72954f3e on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/202
@douddle I created https://issues.apache.org/jira/browse/LANG-1356 to track the bypass issue.
---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/202
[](https://coveralls.io/builds/8692906)
Coverage decreased (-0.02%) to 93.542% when pulling **015fb1125ba10c2894fb858a21eac3ca4c625b9b on PascalSchumacher:recursiveAndReflectiveEqualsBuilder** into **05647d46e9ac2bf674b320e8467616aa72954f3e on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/202
[](https://coveralls.io/builds/8467369)
Coverage decreased (-0.02%) to 93.438% when pulling **b6eee76036d4e44f89f029aa3d45b6842598e69b on PascalSchumacher:recursiveAndReflectiveEqualsBuilder** into **eb2b89efbe15ab0b70fd94f0ecd0aa03866fb4d2 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #202: LANG-1034: Recursive and reflective EqualsBuilder
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/202
[](https://coveralls.io/builds/8467444)
Coverage decreased (-0.04%) to 93.442% when pulling **f4cf194decebba1b6aad156b8a0d146195708676 on PascalSchumacher:recursiveAndReflectiveEqualsBuilder** into **89afbb0c3eaa2d074dc1ef46d09675f24da0e120 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #202: LANG-1034: Recursive and reflective EqualsBu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/202
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---