[GitHub] [incubator-superset] villebro commented on a change in pull request #8699: [SIP-29] Add support for row-level security

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8699: [SIP-29] Add support for row-level security
URL: https://github.com/apache/incubator-superset/pull/8699#discussion_r355206278
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -834,6 +843,10 @@ def get_sqla_query(  # sqla
                         where_clause_and.append(col_obj.get_sqla_col() == None)
                     elif op == "IS NOT NULL":
                         where_clause_and.append(col_obj.get_sqla_col() != None)
+
+        where_clause_and += [
+            text("({})".format(f)) for f in self._get_row_level_filters()
 
 Review comment:
   Agree with @mistercrunch ; currently the `_get_row_level_filters()` is fairly lightweight, and moving the list comprehension away from `get_sqla_query` will keep that particular (already very heavy) method more legible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org