[jira] [Updated] (PHOENIX-7939) UpgradeUtil.getSysTableSnapshotName should use millisecond resolution

["Andrew Kyle Purtell (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PHOENIX-7939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kyle Purtell updated PHOENIX-7939:
-----------------------------------------
    Summary: UpgradeUtil.getSysTableSnapshotName should use millisecond resolution  (was: BackwardCompatibilityIT.testUpsertDeleteWithOldClient flakes with SnapshotCreationException)

> UpgradeUtil.getSysTableSnapshotName should use millisecond resolution
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-7939
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7939
>             Project: Phoenix
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Andrew Kyle Purtell
>            Priority: Major
>
> {{UpgradeUtil.getSysTableSnapshotName(long, String)}} formats its snapshot id suffix with {{SimpleDateFormat("yyyyMMddHHmmss")}}, which has the minimum resolution of only one second. During Phoenix's {{upgradeSystemTables}} path and especially under {{BackwardCompatibilityIT}}'s parameterized replay of old-client upgrades, the same {{SYSTEM.LOG}} snapshot can be requested twice inside the same second. The second request produces an identical snapshot id, HBase's {{SnapshotManager.prepareToTakeSnapshot}} sees an in-flight snapshot with the very same id, and rejects it with {{SnapshotCreationException: "already running another snapshot on the same table"}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)