You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "unbridled-41 (via GitHub)" <gi...@apache.org> on 2026/10/09 20:08:24 UTC
[PR] fix(group): publish the subscribed topics of a listed group [rocketmq-dashboard]
unbridled-41 opened a new pull request, #5962:
URL: https://github.com/apache/rocketmq-dashboard/pull/5962
### Which Issue(s) This PR Fixes
Fixes #5961
### Problem / Evidence
`GroupLiveSnapshot` carried the instance list and lag but not the subscription table, so every listed Apache group shipped the VO default:
```
RocketMQMetadataProviderTest#listConsumerGroupsPageShouldCarryTheGroupsSubscribedTopicsTest
Expecting actual: [] ...
```
The detail read fills the same field from the same connection (`RocketMQAdminClientImpl.getConsumerGroup`), and the web draws the 订阅 Topic 数 card, the topic tags and the CSV column from the *list* row (the page never calls the detail endpoint), while the drawer's own subscription tab fetches the topics separately - so the panel contradicted itself.
### Root cause / Fix
A field the snapshot could not carry. Add `subscribedTopics` to `GroupLiveSnapshot`, fill it from the connection's subscription table in `enrichGroupLiveStats` (sorted, blanks filtered), and copy it onto the VO - leaving the caller's value in place when the enrichment was cut short by the batch deadline (an empty snapshot list means "not read").
### Priority and scoring
**PRIORITY 62** — impact 20/40 (a deterministic wrong count and an empty list for every group, in the drawer, the CSV and the AI detail), blast radius 14/20 (every Apache group row), reproducibility 20/20 (deterministic, pinned by the new test), maintenance value 8/20.
**FIX_CONFIDENCE 80** — no new RPC: the connection is already fetched for the instance list.
### Tests
`cd server && mvn -o -B -ntp test -Dtest='RocketMQMetadataProviderTest'` -> `Tests run: 49, Failures: 0, Errors: 0`; `-Dtest='RocketMQMetadataProviderTest,MetadataServiceTest,ConsumerGroupControllerTest'` -> `Tests run: 131, Failures: 0, Errors: 0`.
| Test | Before | After |
|---|---|---|
| `listConsumerGroupsPageShouldCarryTheGroupsSubscribedTopicsTest` | FAIL (empty list) | PASS (`["orders"]`) |
| the existing enrichment/online cases | PASS | PASS |
`mvn -o -B -ntp checkstyle:check` passes.
### Risk
One extra field per row, filled from data already in hand. Groups whose connection read fails keep the empty list they have today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(group): publish the subscribed topics of a listed group [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5962: fix(group): publish the subscribed topics of a listed group
URL: https://github.com/apache/rocketmq-dashboard/pull/5962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(group): publish the subscribed topics of a listed group [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5962:
URL: https://github.com/apache/rocketmq-dashboard/pull/5962#issuecomment-6091392914
### Verification on the final commit (branch + commit + command results)
Every command from the description re-run on a fresh worktree of this branch (`git worktree add <dir> fork/<branch>`, no local modifications), at commit `4fe3de45a4`:
| command | exit | result |
| --- | --- | --- |
| `cd server && mvn -o -B -ntp test -Dtest='RocketMQMetadataProviderTest'` | 0 | `Tests run: 49, Failures: 0, Errors: 0, Skipped: 0 · BUILD SUCCESS` |
CI note: on this repository the `Backend Build` (binary-license-gate), `Frontend Build` / `Frontend Docker Build` (licence manifest) and `rmqctl Build` (YAML renderer quoting) jobs are red for every branch, trunk included; the module-level commands above are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(group): publish the subscribed topics of a listed group [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5962:
URL: https://github.com/apache/rocketmq-dashboard/pull/5962#issuecomment-6090243657
### CI status of this PR
`Backend Tests (Java 21)` — **pass**; the change-specific commands and their results are in the Tests section of the description.
The four remaining red jobs are red for every branch, including `rocketmq-studio` itself:
- `Backend Build (Java 21)` — the `binary-license-gate` antrun step fails on a list of third-party jars (`spring-ai-*`, `swagger-ui`, `tencentcloud-sdk-*`, `zstd-jni`, ... : "missing complete upstream LICENSE/COPYING; a POM name or link is not a substitute"). This PR touches no build configuration; tracked by #5341.
- `Frontend Build (Node 20)` / `Frontend Docker Build` — the frontend licence manifest check fails the same way on branches that do not touch `web/` at all; tracked by #5346.
- `rmqctl Build (Go)` — `cmd` `TestMessageQueryCompletenessWarningTest` yaml subtests: `got {"items":[{"size":"3",...}]}, want {"size":3,...}`, i.e. the YAML renderer writes numbers as quoted strings where the test expects integer literals. Reproduced locally with `cd rmqctl && go test ./cmd/` from a checkout whose `rmqctl/` tree is byte-identical to `rocketmq-studio`'s, and owned by open PR #5850 ("keep yaml numbers unquoted").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(group): publish the subscribed topics of a listed group [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5962:
URL: https://github.com/apache/rocketmq-dashboard/pull/5962#issuecomment-6227222218
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org