You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/01/18 14:34:04 UTC
Review Request 42458: Made links to .md files consistent across
documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42458/
-----------------------------------------------------------
Review request for mesos, Neil Conway and Till Toenshoff.
Bugs: MESOS-4295
https://issues.apache.org/jira/browse/MESOS-4295
Repository: mesos
Description
-------
Made links to .md files consistent across documentation.
Diffs
-----
docs/allocation-module.md 1dc1abaf9e28abc01de728634593b42c7cfc8af5
docs/app-framework-development-guide.md eedf936457ac2a4b0f0a4f1c3982930beaddca6f
docs/authentication.md 5f13181e93df4dc15a62d5540eeb43c40f91344d
docs/c++-style-guide.md c045a8d5bef171fb475a7d6bc3e78ffb494a6d2e
docs/clang-format.md 206bc2ccf42e5593f715c6ccf0cc42e5cbc62469
docs/committers.md c1ae2574cef66c53886cb36e8ec38d474e3b19f4
docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c
docs/containerizer.md a694de988f3326ac62ff52deba82b659a7080d8d
docs/deploy-scripts.md 0dce7d88cdcdeaf18b585b9c000faf25a1bd5dfa
docs/documentation-guide.md 9548bcabe95a2a26f222022530e6b66d3537c07b
docs/effective-code-reviewing.md fdfafc7d11f8455b68395cd2a4df6dab75f07b22
docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19
docs/fetcher.md d9280e1611df13f8217c9a40a02a5391c44ed267
docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227
docs/home.md 0c52e4805a63b58827dd581907a55712b8a0dc92
docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad
docs/operational-guide.md 811cfc4a634e44a1d2e8db40b44f6b744a1643dd
docs/sandbox.md a2ad226b0ee7969622495f090579f15029a2a083
docs/scheduler-http-api.md 15ffb1e45cc169f4313598aa65aa8b4d41ce2308
docs/tools.md 3e5f4d786ccfcef85b341cdb698c4d0579019980
docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing
-------
Thanks,
Joerg Schad
Re: Review Request 42458: Made links to .md files consistent across
documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42458/
-----------------------------------------------------------
(Updated Jan. 25, 2016, 1:50 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Rebased.
Bugs: MESOS-4295
https://issues.apache.org/jira/browse/MESOS-4295
Repository: mesos
Description
-------
Made links to .md files consistent across documentation.
Diffs (updated)
-----
docs/allocation-module.md 1dc1abaf9e28abc01de728634593b42c7cfc8af5
docs/app-framework-development-guide.md e094f3242682863e05d3f6ee366b081cdda6645f
docs/authentication.md 5f13181e93df4dc15a62d5540eeb43c40f91344d
docs/c++-style-guide.md c045a8d5bef171fb475a7d6bc3e78ffb494a6d2e
docs/clang-format.md 206bc2ccf42e5593f715c6ccf0cc42e5cbc62469
docs/committers.md c1ae2574cef66c53886cb36e8ec38d474e3b19f4
docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c
docs/containerizer.md a694de988f3326ac62ff52deba82b659a7080d8d
docs/deploy-scripts.md 0dce7d88cdcdeaf18b585b9c000faf25a1bd5dfa
docs/documentation-guide.md 9548bcabe95a2a26f222022530e6b66d3537c07b
docs/effective-code-reviewing.md fdfafc7d11f8455b68395cd2a4df6dab75f07b22
docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19
docs/fetcher.md 3cf8875c03fe75daff70f482282d2860ac404734
docs/high-availability.md 02ac7c76d8a597e8457d4ea716e5915542fd2c8b
docs/home.md fa9c19c6d511b8acb7f27c301b21eb369c8f4b47
docs/operational-guide.md 811cfc4a634e44a1d2e8db40b44f6b744a1643dd
docs/sandbox.md a2ad226b0ee7969622495f090579f15029a2a083
docs/tools.md 3e5f4d786ccfcef85b341cdb698c4d0579019980
docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing
-------
Viewed via Docker Website Container (including changes to rakefile provided by previous review).
Thanks,
Joerg Schad
Re: Review Request 42458: Made links to .md files consistent across
documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42458/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 10:50 a.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Removed addition to markdown-styleguide.
Bugs: MESOS-4295
https://issues.apache.org/jira/browse/MESOS-4295
Repository: mesos
Description
-------
Made links to .md files consistent across documentation.
Diffs (updated)
-----
docs/allocation-module.md 1dc1abaf9e28abc01de728634593b42c7cfc8af5
docs/app-framework-development-guide.md eedf936457ac2a4b0f0a4f1c3982930beaddca6f
docs/authentication.md 5f13181e93df4dc15a62d5540eeb43c40f91344d
docs/c++-style-guide.md c045a8d5bef171fb475a7d6bc3e78ffb494a6d2e
docs/clang-format.md 206bc2ccf42e5593f715c6ccf0cc42e5cbc62469
docs/committers.md c1ae2574cef66c53886cb36e8ec38d474e3b19f4
docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c
docs/containerizer.md a694de988f3326ac62ff52deba82b659a7080d8d
docs/deploy-scripts.md 0dce7d88cdcdeaf18b585b9c000faf25a1bd5dfa
docs/documentation-guide.md 9548bcabe95a2a26f222022530e6b66d3537c07b
docs/effective-code-reviewing.md fdfafc7d11f8455b68395cd2a4df6dab75f07b22
docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19
docs/fetcher.md d9280e1611df13f8217c9a40a02a5391c44ed267
docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227
docs/home.md ae3ca71d8ecce63a95697a4d2a657e354d1dfc0e
docs/operational-guide.md 811cfc4a634e44a1d2e8db40b44f6b744a1643dd
docs/sandbox.md a2ad226b0ee7969622495f090579f15029a2a083
docs/tools.md 3e5f4d786ccfcef85b341cdb698c4d0579019980
docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing
-------
Viewed via Docker Website Container (including changes to rakefile provided by previous review).
Thanks,
Joerg Schad
Re: Review Request 42458: Made links to .md files consistent across
documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42458/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 9:09 a.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Bugs: MESOS-4295
https://issues.apache.org/jira/browse/MESOS-4295
Repository: mesos
Description
-------
Made links to .md files consistent across documentation.
Diffs (updated)
-----
docs/allocation-module.md 1dc1abaf9e28abc01de728634593b42c7cfc8af5
docs/app-framework-development-guide.md eedf936457ac2a4b0f0a4f1c3982930beaddca6f
docs/authentication.md 5f13181e93df4dc15a62d5540eeb43c40f91344d
docs/c++-style-guide.md c045a8d5bef171fb475a7d6bc3e78ffb494a6d2e
docs/clang-format.md 206bc2ccf42e5593f715c6ccf0cc42e5cbc62469
docs/committers.md c1ae2574cef66c53886cb36e8ec38d474e3b19f4
docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c
docs/containerizer.md a694de988f3326ac62ff52deba82b659a7080d8d
docs/deploy-scripts.md 0dce7d88cdcdeaf18b585b9c000faf25a1bd5dfa
docs/documentation-guide.md 9548bcabe95a2a26f222022530e6b66d3537c07b
docs/effective-code-reviewing.md fdfafc7d11f8455b68395cd2a4df6dab75f07b22
docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19
docs/fetcher.md d9280e1611df13f8217c9a40a02a5391c44ed267
docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227
docs/home.md ae3ca71d8ecce63a95697a4d2a657e354d1dfc0e
docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad
docs/operational-guide.md 811cfc4a634e44a1d2e8db40b44f6b744a1643dd
docs/sandbox.md a2ad226b0ee7969622495f090579f15029a2a083
docs/tools.md 3e5f4d786ccfcef85b341cdb698c4d0579019980
docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing
-------
Viewed via Docker Website Container (including changes to rakefile provided by previous review).
Thanks,
Joerg Schad
Re: Review Request 42458: Made links to .md files consistent across
documentation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42458/#review115133
-----------------------------------------------------------
Ship it!
Thanks Joerg!
docs/markdown-style-guide.md (line 120)
<https://reviews.apache.org/r/42458/#comment175993>
I would like to make it a bit more deterministic...
How about something like:
```
We use the following format for links pointing to pages within the documentation folder:
```
- Till Toenshoff
On Jan. 19, 2016, 7:52 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42458/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 7:52 a.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-4295
> https://issues.apache.org/jira/browse/MESOS-4295
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made links to .md files consistent across documentation.
>
>
> Diffs
> -----
>
> docs/allocation-module.md 1dc1abaf9e28abc01de728634593b42c7cfc8af5
> docs/app-framework-development-guide.md eedf936457ac2a4b0f0a4f1c3982930beaddca6f
> docs/authentication.md 5f13181e93df4dc15a62d5540eeb43c40f91344d
> docs/c++-style-guide.md c045a8d5bef171fb475a7d6bc3e78ffb494a6d2e
> docs/clang-format.md 206bc2ccf42e5593f715c6ccf0cc42e5cbc62469
> docs/committers.md c1ae2574cef66c53886cb36e8ec38d474e3b19f4
> docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c
> docs/containerizer.md a694de988f3326ac62ff52deba82b659a7080d8d
> docs/deploy-scripts.md 0dce7d88cdcdeaf18b585b9c000faf25a1bd5dfa
> docs/documentation-guide.md 9548bcabe95a2a26f222022530e6b66d3537c07b
> docs/effective-code-reviewing.md fdfafc7d11f8455b68395cd2a4df6dab75f07b22
> docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19
> docs/fetcher.md d9280e1611df13f8217c9a40a02a5391c44ed267
> docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227
> docs/home.md ae3ca71d8ecce63a95697a4d2a657e354d1dfc0e
> docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad
> docs/operational-guide.md 811cfc4a634e44a1d2e8db40b44f6b744a1643dd
> docs/sandbox.md a2ad226b0ee7969622495f090579f15029a2a083
> docs/tools.md 3e5f4d786ccfcef85b341cdb698c4d0579019980
> docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
>
> Diff: https://reviews.apache.org/r/42458/diff/
>
>
> Testing
> -------
>
> Viewed via Docker Website Container (including changes to rakefile provided by previous review).
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42458: Made links to .md files consistent across
documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42458/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 7:52 a.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Rebased.
Bugs: MESOS-4295
https://issues.apache.org/jira/browse/MESOS-4295
Repository: mesos
Description
-------
Made links to .md files consistent across documentation.
Diffs (updated)
-----
docs/allocation-module.md 1dc1abaf9e28abc01de728634593b42c7cfc8af5
docs/app-framework-development-guide.md eedf936457ac2a4b0f0a4f1c3982930beaddca6f
docs/authentication.md 5f13181e93df4dc15a62d5540eeb43c40f91344d
docs/c++-style-guide.md c045a8d5bef171fb475a7d6bc3e78ffb494a6d2e
docs/clang-format.md 206bc2ccf42e5593f715c6ccf0cc42e5cbc62469
docs/committers.md c1ae2574cef66c53886cb36e8ec38d474e3b19f4
docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c
docs/containerizer.md a694de988f3326ac62ff52deba82b659a7080d8d
docs/deploy-scripts.md 0dce7d88cdcdeaf18b585b9c000faf25a1bd5dfa
docs/documentation-guide.md 9548bcabe95a2a26f222022530e6b66d3537c07b
docs/effective-code-reviewing.md fdfafc7d11f8455b68395cd2a4df6dab75f07b22
docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19
docs/fetcher.md d9280e1611df13f8217c9a40a02a5391c44ed267
docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227
docs/home.md ae3ca71d8ecce63a95697a4d2a657e354d1dfc0e
docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad
docs/operational-guide.md 811cfc4a634e44a1d2e8db40b44f6b744a1643dd
docs/sandbox.md a2ad226b0ee7969622495f090579f15029a2a083
docs/tools.md 3e5f4d786ccfcef85b341cdb698c4d0579019980
docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing
-------
Viewed via Docker Website Container (including changes to rakefile provided by previous review).
Thanks,
Joerg Schad
Re: Review Request 42458: Made links to .md files consistent across
documentation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42458/#review115016
-----------------------------------------------------------
Bad patch!
Reviews applied: [42457, 42458]
Failed command: ./support/apply-review.sh -n -r 42458
Error:
2016-01-18 16:31:18 URL:https://reviews.apache.org/r/42458/diff/raw/ [35837/35837] -> "42458.patch" [1]
error: patch failed: docs/home.md:6
error: docs/home.md: patch does not apply
error: patch failed: docs/scheduler-http-api.md:514
error: docs/scheduler-http-api.md: patch does not apply
- Mesos ReviewBot
On Jan. 18, 2016, 1:36 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42458/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 1:36 p.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-4295
> https://issues.apache.org/jira/browse/MESOS-4295
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made links to .md files consistent across documentation.
>
>
> Diffs
> -----
>
> docs/allocation-module.md 1dc1abaf9e28abc01de728634593b42c7cfc8af5
> docs/app-framework-development-guide.md eedf936457ac2a4b0f0a4f1c3982930beaddca6f
> docs/authentication.md 5f13181e93df4dc15a62d5540eeb43c40f91344d
> docs/c++-style-guide.md c045a8d5bef171fb475a7d6bc3e78ffb494a6d2e
> docs/clang-format.md 206bc2ccf42e5593f715c6ccf0cc42e5cbc62469
> docs/committers.md c1ae2574cef66c53886cb36e8ec38d474e3b19f4
> docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c
> docs/containerizer.md a694de988f3326ac62ff52deba82b659a7080d8d
> docs/deploy-scripts.md 0dce7d88cdcdeaf18b585b9c000faf25a1bd5dfa
> docs/documentation-guide.md 9548bcabe95a2a26f222022530e6b66d3537c07b
> docs/effective-code-reviewing.md fdfafc7d11f8455b68395cd2a4df6dab75f07b22
> docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19
> docs/fetcher.md d9280e1611df13f8217c9a40a02a5391c44ed267
> docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227
> docs/home.md 0c52e4805a63b58827dd581907a55712b8a0dc92
> docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad
> docs/operational-guide.md 811cfc4a634e44a1d2e8db40b44f6b744a1643dd
> docs/sandbox.md a2ad226b0ee7969622495f090579f15029a2a083
> docs/scheduler-http-api.md 15ffb1e45cc169f4313598aa65aa8b4d41ce2308
> docs/tools.md 3e5f4d786ccfcef85b341cdb698c4d0579019980
> docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
>
> Diff: https://reviews.apache.org/r/42458/diff/
>
>
> Testing
> -------
>
> Viewed via Docker Website Container (including changes to rakefile provided by previous review).
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42458: Made links to .md files consistent across
documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42458/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 1:36 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Bugs: MESOS-4295
https://issues.apache.org/jira/browse/MESOS-4295
Repository: mesos
Description
-------
Made links to .md files consistent across documentation.
Diffs
-----
docs/allocation-module.md 1dc1abaf9e28abc01de728634593b42c7cfc8af5
docs/app-framework-development-guide.md eedf936457ac2a4b0f0a4f1c3982930beaddca6f
docs/authentication.md 5f13181e93df4dc15a62d5540eeb43c40f91344d
docs/c++-style-guide.md c045a8d5bef171fb475a7d6bc3e78ffb494a6d2e
docs/clang-format.md 206bc2ccf42e5593f715c6ccf0cc42e5cbc62469
docs/committers.md c1ae2574cef66c53886cb36e8ec38d474e3b19f4
docs/containerizer-internals.md 14c4c6ce5ed2a28defb7d6623c45ee337f1e6c3c
docs/containerizer.md a694de988f3326ac62ff52deba82b659a7080d8d
docs/deploy-scripts.md 0dce7d88cdcdeaf18b585b9c000faf25a1bd5dfa
docs/documentation-guide.md 9548bcabe95a2a26f222022530e6b66d3537c07b
docs/effective-code-reviewing.md fdfafc7d11f8455b68395cd2a4df6dab75f07b22
docs/fetcher-cache-internals.md b71d22591b8213be2e2a37555895176b8a6a4e19
docs/fetcher.md d9280e1611df13f8217c9a40a02a5391c44ed267
docs/high-availability.md 31aa66220617a3f8606b185ef247c11f00735227
docs/home.md 0c52e4805a63b58827dd581907a55712b8a0dc92
docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad
docs/operational-guide.md 811cfc4a634e44a1d2e8db40b44f6b744a1643dd
docs/sandbox.md a2ad226b0ee7969622495f090579f15029a2a083
docs/scheduler-http-api.md 15ffb1e45cc169f4313598aa65aa8b4d41ce2308
docs/tools.md 3e5f4d786ccfcef85b341cdb698c4d0579019980
docs/versioning.md 7af6581f2eef10c78c76c07c44e88c6841465398
Diff: https://reviews.apache.org/r/42458/diff/
Testing (updated)
-------
Viewed via Docker Website Container (including changes to rakefile provided by previous review).
Thanks,
Joerg Schad