[GitHub] [flink] MartijnVisser commented on a diff in pull request #21696: [FLINK-30257] fix SqlClientITCase#testMatchRecognize

["MartijnVisser (via GitHub)" <gi...@apache.org>]

MartijnVisser commented on code in PR #21696:
URL: https://github.com/apache/flink/pull/21696#discussion_r1098698756


##########
flink-end-to-end-tests/flink-sql-client-test/src/test/java/SqlClientITCase.java:
##########
@@ -290,10 +290,15 @@ private void verifyNumberOfResultRecords(String resultFilePath, int expectedNumb
         File tempOutputFile = new File(tempDir, "records.out");
         String tempOutputFilepath = tempOutputFile.toString();
         GenericContainer<?> taskManager = flink.getTaskManagers().get(0);
-        Thread.sleep(5000); // prevent NotFoundException: Status 404
-        taskManager.copyFileFromContainer(resultFilePath, tempOutputFilepath);
-
-        int numberOfResultRecords = UpsertTestFileUtil.getNumberOfRecords(tempOutputFile);
+        int numberOfResultRecords;
+        while (true) {
+            Thread.sleep(5000); // prevent NotFoundException: Status 404

Review Comment:
   @WencongLiu Could you lower the sleep? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org