[GitHub] wujimin commented on a change in pull request #803: [SCB-706]change filters to discovery filters and support invocation based filters

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #803:  [SCB-706]change filters to discovery filters and support invocation based filters
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/803#discussion_r202051415
 
 

 ##########
 File path: handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/ServiceCombServer.java
 ##########
 @@ -79,29 +69,16 @@ public String getHost() {
     return endpoint.getEndpoint();
   }
 
-  public void clearContinuousFailure() {
-    continuousFailureCount.set(0);
-  }
-
-  public void incrementContinuousFailureCount() {
-    if (continuousFailureCount.get() < Integer.MAX_VALUE) {
-      continuousFailureCount.incrementAndGet();
-    }
-  }
-
-  public int getCountinuousFailureCount() {
-    return continuousFailureCount.get();
-  }
-
+  // take endpoints that belongs to same instance as same server
   public boolean equals(Object o) {
-    if (o instanceof CseServer) {
-      return this.getHost().equals(((CseServer) o).getHost());
+    if (o instanceof ServiceCombServer) {
 
 Review comment:
   rest endpoint equals highway endpoint?
   why?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services