You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "zstan (via GitHub)" <gi...@apache.org> on 2023/06/28 07:28:19 UTC
[GitHub] [ignite-3] zstan commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed
zstan commented on code in PR #2241:
URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1244802526
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##########
@@ -690,7 +689,7 @@ public void closeSession() {
assertThrowsWithCause(
() -> await(ars0.fetchNextPage()),
- ExecutionCancelledException.class
+ CursorClosedException.class
Review Comment:
and what about already exist :
https://github.com/apache/ignite-3/blob/cae90410a32ba3946d09f6a135683f9c3e231f38/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java#L636
https://github.com/apache/ignite-3/blob/cae90410a32ba3946d09f6a135683f9c3e231f38/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlSynchronousApiTest.java#L330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org