You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "rich7420 (via GitHub)" <gi...@apache.org> on 2026/10/09 22:35:15 UTC

[PR] HDDS-16749. Avoid regex compilation when splitting canonical URIs for S3 signatures [ozone]

rich7420 opened a new pull request, #11460:
URL: https://github.com/apache/ozone/pull/11460

   ## What changes were proposed in this pull request?
   
   Canonical URI construction currently compiles a regex to split URI path segments for each S3 signature. Use the existing commons-lang3 `StringUtils.splitPreserveAllTokens` with a slash separator and remove the regex helper.
   
   Leading, trailing, and repeated separators remain preserved, and each segment is encoded as before. Parameterized tests cover empty paths, repeated separators, dot segments, percent escapes, spaces, and Unicode.
   
   ## What is the link to the Apache JIRA?
   
   https://issues.apache.org/jira/browse/HDDS-16749
   
   ## How was this patch tested?
   
   - Six S3 signature test classes: 68 tests passed locally; checkstyle and S3 Gateway PMD passed.
   - [Latest fork CI](https://github.com/rich7420/ozone/actions/runs/37800764520): OM integration failed in `testClientWithLocalLeaseEnabled`, client integration failed in `TestFailureHandlingByClient.testContainerExclusionWithClosedContainerException`, and Kubernetes failed in the Freon Ozone Client Key Generator and Key Validator. These paths do not use S3 canonical URI construction. Other checks that ran passed.
   
   Generated-by: Codex (GPT-6)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16749. Avoid regex compilation when splitting canonical URIs for S3 signatures [ozone]

Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #11460:
URL: https://github.com/apache/ozone/pull/11460#issuecomment-6094403015

   thanks for the review @chihsuan and @smengcl 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16749. Avoid regex compilation when splitting canonical URIs for S3 signatures [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11460:
URL: https://github.com/apache/ozone/pull/11460#issuecomment-6094263898

   Please keep ~1 hour between merges to `master` to avoid flooding GitHub Actions queue, leaving room for PRs and other jobs.
   
   Also, to accommodate contributors from all time zones, please give at least 24 hours for feedback before merging PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16749. Avoid regex compilation when splitting canonical URIs for S3 signatures [ozone]

Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #11460:
URL: https://github.com/apache/ozone/pull/11460#issuecomment-6093915913

   Thanks @rich7420 for the patch. Thanks @chihsuan for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-16749. Avoid regex compilation when splitting canonical URIs for S3 signatures [ozone]

Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl merged PR #11460:
URL: https://github.com/apache/ozone/pull/11460


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org