You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <ma...@james.apache.org> on 2007/05/07 21:10:16 UTC

[jira] Commented: (MAILET-5) Currently our getRecipients expose the internal collection and it is used that way.

    [ https://issues.apache.org/jira/browse/MAILET-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494111 ] 

Norman Maurer commented on MAILET-5:
------------------------------------

Moved from JAMES-558

> Currently our getRecipients expose the internal collection and it is used that way.
> -----------------------------------------------------------------------------------
>
>                 Key: MAILET-5
>                 URL: https://issues.apache.org/jira/browse/MAILET-5
>             Project: Mailet API
>          Issue Type: Improvement
>            Reporter: Norman Maurer
>         Assigned To: Norman Maurer
>
> Currently our getRecipients expose the internal collection and it is used that way.
> To add recipients we use getRecipients().add(), to store multiple times a single mail to different recipients we get the recipients collection and alter it between store of the mail object (in RemoteDelivery).
> All of this seems to me bad practice and we should better encapsulate the recipients list in the mail object.
> Maybe the simple way is to return immutable collections so we'll find bugs as soon as possible and add methods to add and remove recipients directly in the mail interface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org