You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by zm...@avadasoftware.com on 2018/10/11 20:15:06 UTC

GitHub Pull Requests

Hello,

I have submitted a Pull Request at 
https://github.com/apache/commons-lang/pull/358.  10 days ago, 
"coveralls" commented on the request and all checks passed.  Otherwise, 
I have heard nothing regarding the request.

When do requests get reviewed and/or commented on?

Thanks,
Zack Macomber

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: GitHub Pull Requests

Posted by Sudeendra Nadager <su...@outlook.com>.
Dear Zack,

I gave a shot at it. I have some comments and see if they make sense.

Regards,
Sudeendra Nadager

On 13/10/18, 01:33, "Pascal Schumacher" <pa...@gmx.net> wrote:

    Hi Zack,
    
    there is no hard and fast rule when pull request get reviewed and/or 
    commented on.
    
    It happens whenever a committer feels motivated to do so (we are all 
    volunteers).
    
    I understand that waiting a long time for pull request reviews is 
    demotivating.
    
    Sorry,
    Pascal
    
    Am 11.10.2018 um 22:15 schrieb zmacomber@avadasoftware.com:
    > Hello,
    >
    > I have submitted a Pull Request at 
    > https://github.com/apache/commons-lang/pull/358.  10 days ago, 
    > "coveralls" commented on the request and all checks passed. Otherwise, 
    > I have heard nothing regarding the request.
    >
    > When do requests get reviewed and/or commented on?
    >
    > Thanks,
    > Zack Macomber
    >
    > ---------------------------------------------------------------------
    > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
    > For additional commands, e-mail: dev-help@commons.apache.org
    >
    
    
    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
    For additional commands, e-mail: dev-help@commons.apache.org
    
    


Re: GitHub Pull Requests

Posted by Pascal Schumacher <pa...@gmx.net>.
Hi Zack,

there is no hard and fast rule when pull request get reviewed and/or 
commented on.

It happens whenever a committer feels motivated to do so (we are all 
volunteers).

I understand that waiting a long time for pull request reviews is 
demotivating.

Sorry,
Pascal

Am 11.10.2018 um 22:15 schrieb zmacomber@avadasoftware.com:
> Hello,
>
> I have submitted a Pull Request at 
> https://github.com/apache/commons-lang/pull/358.  10 days ago, 
> "coveralls" commented on the request and all checks passed. Otherwise, 
> I have heard nothing regarding the request.
>
> When do requests get reviewed and/or commented on?
>
> Thanks,
> Zack Macomber
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org