[GitHub] [superset] mike-pt commented on issue #24195: supersetEmbeddedSdk filters.visible = false doesn't seem to work

["mike-pt (via GitHub)" <gi...@apache.org>]

mike-pt commented on issue #24195:
URL: https://github.com/apache/superset/issues/24195#issuecomment-1592018319

   Maybe this helps:
   
   https://github.com/apache/superset/commit/eb805682e2d9b8ff6c4bda446e665d1045afe55f
   
   ``` /** The dashboard UI config: hideTitle, hideTab, hideChartControls,
   filters.visible, filters.expanded **/ ```  <---
   
   which no longer seems to be the case... there's also several posts in slack
   about this... and even examples posted on how to hide filters...
   
   Maybe that was always buggy and got removed... that much I don't know
   because the release notes unfortunately don't mention this and I was lazy
   to dig into more code or PRs etc
   
   Anyway the fact is there is a lot of evidence to suggest this was indeed a
   thing, and it no longer is, so if you want to set this as FR instead of BUG
   I think it's fine, but it's definitely much needed, there's more than one
   thread on slack, I just decided to bring it over Github because it seemed
   like the correct approach perhaps it wasn't
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org