You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/03/07 03:47:59 UTC
[kudu-CR] [util] fixed env util-test.cc compilation on OS X
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6282
Change subject: [util] fixed env_util-test.cc compilation on OS X
......................................................................
[util] fixed env_util-test.cc compilation on OS X
The prior version failed to compile on OS X with clang version 3.9.0
(branches/release_39 277311) with error messaged containing:
/opt/local/libexec/llvm-3.9/bin/../include/c++/v1/algorithm:2643:1:
note:
candidate template ignored: deduced conflicting types for parameter
'_Tp' ('long' vs. 'long long')
max(const _Tp& __a, const _Tp& __b)
^
/opt/local/libexec/llvm-3.9/bin/../include/c++/v1/algorithm:2653:1:
note:
candidate template ignored: could not match
'initializer_list<type-parameter-0-0>' against 'long'
max(initializer_list<_Tp> __t, _Compare __comp)
^
Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897
---
M src/kudu/util/env_util-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/6282/1
--
To view, visit http://gerrit.cloudera.org:8080/6282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] fixed env util-test.cc compilation on OS X
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [util] fixed env_util-test.cc compilation on OS X
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6282/1/src/kudu/util/env_util-test.cc
File src/kudu/util/env_util-test.cc:
PS1, Line 71: std::max(int64_t(0)
I think the usual way to do this is std::max<int64_t>(0, ...)
--
To view, visit http://gerrit.cloudera.org:8080/6282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env util-test.cc compilation on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [util] fixed env_util-test.cc compilation on OS X
......................................................................
[util] fixed env_util-test.cc compilation on OS X
The prior version failed to compile on OS X with clang version 3.9.0
(branches/release_39 277311) with error messaged containing:
/opt/local/libexec/llvm-3.9/bin/../include/c++/v1/algorithm:2643:1:
note:
candidate template ignored: deduced conflicting types for parameter
'_Tp' ('long' vs. 'long long')
max(const _Tp& __a, const _Tp& __b)
^
/opt/local/libexec/llvm-3.9/bin/../include/c++/v1/algorithm:2653:1:
note:
candidate template ignored: could not match
'initializer_list<type-parameter-0-0>' against 'long'
max(initializer_list<_Tp> __t, _Compare __comp)
^
Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897
---
M src/kudu/util/env_util-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/6282/2
--
To view, visit http://gerrit.cloudera.org:8080/6282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [util] fixed env util-test.cc compilation on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [util] fixed env_util-test.cc compilation on OS X
......................................................................
[util] fixed env_util-test.cc compilation on OS X
The prior version failed to compile on OS X with clang version 3.9.0
(branches/release_39 277311) with error messaged containing:
/opt/local/libexec/llvm-3.9/bin/../include/c++/v1/algorithm:2643:1:
note:
candidate template ignored: deduced conflicting types for parameter
'_Tp' ('long' vs. 'long long')
max(const _Tp& __a, const _Tp& __b)
^
/opt/local/libexec/llvm-3.9/bin/../include/c++/v1/algorithm:2653:1:
note:
candidate template ignored: could not match
'initializer_list<type-parameter-0-0>' against 'long'
max(initializer_list<_Tp> __t, _Compare __comp)
^
Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897
Reviewed-on: http://gerrit.cloudera.org:8080/6282
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/env_util-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [util] fixed env util-test.cc compilation on OS X
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [util] fixed env_util-test.cc compilation on OS X
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [util] fixed env util-test.cc compilation on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [util] fixed env_util-test.cc compilation on OS X
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6282/1/src/kudu/util/env_util-test.cc
File src/kudu/util/env_util-test.cc:
PS1, Line 71: std::max(int64_t(0)
> I think the usual way to do this is std::max<int64_t>(0, ...)
Yep, that would be better. Just tried to have it closer to the original version :)
--
To view, visit http://gerrit.cloudera.org:8080/6282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ce139c9896a969d51bfcaeabdf6133287c3a897
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes