You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Eric Pugh <ep...@upstate.com> on 2003/11/13 11:50:22 UTC
[VOTE] Add dependency on commons-http?
Hi all,
A post on the user list from Jeff Painter made me go look at the HttpUtils
class.. It had a bug in the date format for HTTPUtils. And low and behold,
it is deprecated and to be removed in 2.3. However, it is another commons-
jar, and in the sandbox as well[1]. Since we have plenty of dependencies on
commons- stuff in sandbox, I don't know if it is a big deal or not. But, I
either want to un deprecate the code and fix it in the Turbine code base, or
delete it, and fix the bug in the commons-http code base.
This also applies to the BrowserDetector class as well.
[ ] Yes, delete the deprecated code and add a dependency on commons-http
[ ] No, fix the deprecated code, and undeprecate it.
[1]
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/http/src/java/org/apac
he/commons/http/HttpUtils.java?rev=1.1&content-type=text/vnd.viewcvs-markup
Eric Pugh
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [VOTE] Add dependency on commons-http?
Posted by Martin Poeschl <mp...@marmot.at>.
Eric Pugh wrote:
>Hi all,
>
>A post on the user list from Jeff Painter made me go look at the HttpUtils
>class.. It had a bug in the date format for HTTPUtils. And low and behold,
>it is deprecated and to be removed in 2.3. However, it is another commons-
>jar, and in the sandbox as well[1]. Since we have plenty of dependencies on
>commons- stuff in sandbox, I don't know if it is a big deal or not. But, I
>either want to un deprecate the code and fix it in the Turbine code base, or
>delete it, and fix the bug in the commons-http code base.
>
>This also applies to the BrowserDetector class as well.
>
>[x] Yes, delete the deprecated code and add a dependency on commons-http
>[ ] No, fix the deprecated code, and undeprecate it.
>
>
martin
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [VOTE RESULTS] Add dependency on commons-http?
Posted by Peter Courcoux <pe...@courcoux.biz>.
I am also concerned with lack of interest in commons components. I
submitted a patch to commons-dev in June to add support for upload
progress reporting and despite reminders and occasional 'I'll get to it
as soon as I can' responses the code has neither been accepted nor
rejected.
I'd like to see a patched version of the file-upload code in fulcrum as
an option for users.
Regards,
Peter
On Fri, 2003-11-21 at 19:31, Eric Pugh wrote:
> Hi all,
>
> Well, the results where somewhat inconclusive.. There where 3 +1's, but two
> comments that depending on code with questionable support can be bad. And I
> kinda want to change my vote to a -1!
>
> I'd like to change my vote to a -1, as I know this code will NEVER EVER
> leave sandbox, and adding yet another dependency doesn't make sense. It's
> three little classes that aren't rocket science. I am going to fix the code
> in turbine 2.4, and I'd like someone to convince me why we should depend on
> it. The code entered sandbox when lots of good parts of Turbine where
> pulled out (like the basis for commons-lang).
>
> Eric
>
> > -----Original Message-----
> > From: Stephen McConnell [mailto:mcconnell@apache.org]
> > Sent: Friday, November 14, 2003 3:59 AM
> > To: Turbine Developers List
> > Subject: Re: [VOTE] Add dependency on commons-http?
> >
> >
> >
> >
> > Scott Eade wrote:
> >
> > >
> > >> [x] Yes, delete the deprecated code and add a dependency
> > on commons-http
> > >> [ ] No, fix the deprecated code, and undeprecate it.
> > >>
> > > BUT: commons-http is not being maintained by anyone at present - it
> > > doesn't even appear on the commons components page and the
> > last commit
> > > was 7 months ago.
> > > I use commons-http in my application so as to avoid the deprecation
> > > warning from BrowserDetector, but commons-http needs to be
> > patched in
> > > order to do what I want (public access to the constants),
> > but due to
> > > the low level of attention commons-http gets my patch was
> > lost in the
> > > massive flow of traffic that is commons-dev:
> > >
> > >
> > http://nagoya.apache.org/eyebrowse/ReadMsg?listName=commons-de
> v@jakarta.apache.org&msgNo=32393
> >
> >
> > commons-http is a really small component - I agree that it should be
> > fixed and then released. If there is not enough interest in releasing
> > it then I think it should be rolled it back into turbine.
>
>
> My first reaction would be to roll-it-back. Depending on something that
> has a questionable communiy/backing is bit a good idea.
>
> Stephen.
>
> >
> >
> > Scott
> >
>
> --
>
> Stephen J. McConnell
> mailto:mcconnell@apache.org
>
> |------------------------------------------------|
> | Magic by Merlin |
> | Production by Avalon |
> | |
> | http://avalon.apache.org/merlin |
> | http://dpml.net/ |
> |------------------------------------------------|
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
--
Peter Courcoux <pe...@courcoux.biz>
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
[VOTE RESULTS] Add dependency on commons-http?
Posted by Eric Pugh <ep...@upstate.com>.
Hi all,
Well, the results where somewhat inconclusive.. There where 3 +1's, but two
comments that depending on code with questionable support can be bad. And I
kinda want to change my vote to a -1!
I'd like to change my vote to a -1, as I know this code will NEVER EVER
leave sandbox, and adding yet another dependency doesn't make sense. It's
three little classes that aren't rocket science. I am going to fix the code
in turbine 2.4, and I'd like someone to convince me why we should depend on
it. The code entered sandbox when lots of good parts of Turbine where
pulled out (like the basis for commons-lang).
Eric
> -----Original Message-----
> From: Stephen McConnell [mailto:mcconnell@apache.org]
> Sent: Friday, November 14, 2003 3:59 AM
> To: Turbine Developers List
> Subject: Re: [VOTE] Add dependency on commons-http?
>
>
>
>
> Scott Eade wrote:
>
> >
> >> [x] Yes, delete the deprecated code and add a dependency
> on commons-http
> >> [ ] No, fix the deprecated code, and undeprecate it.
> >>
> > BUT: commons-http is not being maintained by anyone at present - it
> > doesn't even appear on the commons components page and the
> last commit
> > was 7 months ago.
> > I use commons-http in my application so as to avoid the deprecation
> > warning from BrowserDetector, but commons-http needs to be
> patched in
> > order to do what I want (public access to the constants),
> but due to
> > the low level of attention commons-http gets my patch was
> lost in the
> > massive flow of traffic that is commons-dev:
> >
> >
> http://nagoya.apache.org/eyebrowse/ReadMsg?listName=commons-de
v@jakarta.apache.org&msgNo=32393
>
>
> commons-http is a really small component - I agree that it should be
> fixed and then released. If there is not enough interest in releasing
> it then I think it should be rolled it back into turbine.
My first reaction would be to roll-it-back. Depending on something that
has a questionable communiy/backing is bit a good idea.
Stephen.
>
>
> Scott
>
--
Stephen J. McConnell
mailto:mcconnell@apache.org
|------------------------------------------------|
| Magic by Merlin |
| Production by Avalon |
| |
| http://avalon.apache.org/merlin |
| http://dpml.net/ |
|------------------------------------------------|
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [VOTE] Add dependency on commons-http?
Posted by Stephen McConnell <mc...@apache.org>.
Scott Eade wrote:
>
>> [x] Yes, delete the deprecated code and add a dependency on commons-http
>> [ ] No, fix the deprecated code, and undeprecate it.
>>
> BUT: commons-http is not being maintained by anyone at present - it
> doesn't even appear on the commons components page and the last commit
> was 7 months ago.
> I use commons-http in my application so as to avoid the deprecation
> warning from BrowserDetector, but commons-http needs to be patched in
> order to do what I want (public access to the constants), but due to
> the low level of attention commons-http gets my patch was lost in the
> massive flow of traffic that is commons-dev:
>
> http://nagoya.apache.org/eyebrowse/ReadMsg?listName=commons-dev@jakarta.apache.org&msgNo=32393
>
>
> commons-http is a really small component - I agree that it should be
> fixed and then released. If there is not enough interest in releasing
> it then I think it should be rolled it back into turbine.
My first reaction would be to roll-it-back. Depending on something that
has a questionable communiy/backing is bit a good idea.
Stephen.
>
>
> Scott
>
--
Stephen J. McConnell
mailto:mcconnell@apache.org
|------------------------------------------------|
| Magic by Merlin |
| Production by Avalon |
| |
| http://avalon.apache.org/merlin |
| http://dpml.net/ |
|------------------------------------------------|
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: [VOTE] Add dependency on commons-http?
Posted by Scott Eade <se...@backstagetech.com.au>.
>[x] Yes, delete the deprecated code and add a dependency on commons-http
>[ ] No, fix the deprecated code, and undeprecate it.
>
BUT: commons-http is not being maintained by anyone at present - it
doesn't even appear on the commons components page and the last commit
was 7 months ago.
I use commons-http in my application so as to avoid the deprecation
warning from BrowserDetector, but commons-http needs to be patched in
order to do what I want (public access to the constants), but due to the
low level of attention commons-http gets my patch was lost in the
massive flow of traffic that is commons-dev:
http://nagoya.apache.org/eyebrowse/ReadMsg?listName=commons-dev@jakarta.apache.org&msgNo=32393
commons-http is a really small component - I agree that it should be
fixed and then released. If there is not enough interest in releasing
it then I think it should be rolled it back into turbine.
Scott
--
Scott Eade
Backstage Technologies Pty. Ltd.
http://www.backstagetech.com.au
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
RE: [VOTE] Add dependency on commons-http?
Posted by Eric Pugh <ep...@upstate.com>.
Here is my vote:
[X ] Yes, delete the deprecated code and add a dependency on
commons-http
[ ] No, fix the deprecated code, and undeprecate it.
Eric
> -----Original Message-----
> From: Eric Pugh [mailto:epugh@upstate.com]
> Sent: Thursday, November 13, 2003 11:50 AM
> To: 'Turbine Developers List'
> Subject: [VOTE] Add dependency on commons-http?
>
>
> Hi all,
>
> A post on the user list from Jeff Painter made me go look at
> the HttpUtils
> class.. It had a bug in the date format for HTTPUtils. And
> low and behold,
> it is deprecated and to be removed in 2.3. However, it is
> another commons-
> jar, and in the sandbox as well[1]. Since we have plenty of
> dependencies on
> commons- stuff in sandbox, I don't know if it is a big deal
> or not. But, I
> either want to un deprecate the code and fix it in the
> Turbine code base, or
> delete it, and fix the bug in the commons-http code base.
>
> This also applies to the BrowserDetector class as well.
>
> [ ] Yes, delete the deprecated code and add a dependency on
> commons-http
> [ ] No, fix the deprecated code, and undeprecate it.
>
>
> [1]
> http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/http/src
> /java/org/apac
> he/commons/http/HttpUtils.java?rev=1.1&content-type=text/vnd.v
> iewcvs-markup
>
>
> Eric Pugh
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org