[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall

[GitBox <gi...@apache.org>]

anirudh2290 commented on a change in pull request #14397: Add exception handling support for waitall
URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r267557161
 
 

 ##########
 File path: src/engine/threaded_engine.cc
 ##########
 @@ -428,6 +447,14 @@ inline void ThreadedEngine::OnComplete(ThreadedOpr* threaded_opr) {
   for (auto&& i : threaded_opr->mutable_vars) {
     if (threaded_opr->opr_exception && *threaded_opr->opr_exception) {
       i->var_exception = threaded_opr->opr_exception;
+      // add current operator exceptions to global exceptions if not already
+      // added
+      auto it = std::find(global_exception_refs_.begin(),
 
 Review comment:
   Thanks for the review ! I have moved it into a function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services