You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2024/08/07 08:51:47 UTC

[PR] Fix links and remove per-module pages (logging-log4j2)

ppkarwasz opened a new pull request, #2800:
URL: https://github.com/apache/logging-log4j2/pull/2800

   This PR:
   
   - fixes internal links as far as IDEA can find.
   - removes most `log4j-<something>.adoc` pages, if their content is available elsewhere. For example `log4j-docker` is completely described in `lookups.adoc`.
   
   This is the last documentation touch of #2542.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix links and remove per-module pages (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #2800:
URL: https://github.com/apache/logging-log4j2/pull/2800#discussion_r1708666220


##########
src/site/antora/modules/ROOT/pages/manual/appenders/message-queue.adoc:
##########


Review Comment:
   Don't these two corrections imply that associated features were never used by anyone?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix links and remove per-module pages (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #2800:
URL: https://github.com/apache/logging-log4j2/pull/2800


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix links and remove per-module pages (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #2800:
URL: https://github.com/apache/logging-log4j2/pull/2800#discussion_r1708730410


##########
src/site/antora/modules/ROOT/pages/manual/appenders/message-queue.adoc:
##########


Review Comment:
   These instructions were in the current [`log4j-flume-ng.adoc`](
   https://github.com/apache/logging-log4j2/blob/4b2f377114ec64f38eeadcab2d425dba48b94348/src/site/antora/modules/ROOT/pages/log4j-flume-ng.adoc) file.
   
   Not sure if anybody actually uses them. @rgoers, any idea?
   The `PERSISTENCE` manager uses a rarely updated `je` library, whose only advantage is that it is ASL licensed. If the dependency was not in the documentation we could switch to the better maintained, EPL licensed and smaller `h2` library.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix links and remove per-module pages (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #2800:
URL: https://github.com/apache/logging-log4j2/pull/2800#discussion_r1708726909


##########
src/site/antora/modules/ROOT/pages/soa.adoc:
##########
@@ -167,7 +167,7 @@ In this section, we will share guides on some popular integration scenarios.
 [#docker]
 === Docker
 
-See xref:log4j-docker.adoc[Log4j Docker] for Docker-specific Log4j features, e.g., xref:manual/lookups.adoc#DockerLookup[Docker Lookup].
+See xref:manual/lookups.adoc#DockerLookup[Docker Lookup].

Review Comment:
   Could you restore this sentence in #2806, please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix links and remove per-module pages (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #2800:
URL: https://github.com/apache/logging-log4j2/pull/2800#discussion_r1708815121


##########
src/site/antora/modules/ROOT/pages/soa.adoc:
##########
@@ -167,7 +167,7 @@ In this section, we will share guides on some popular integration scenarios.
 [#docker]
 === Docker
 
-See xref:log4j-docker.adoc[Log4j Docker] for Docker-specific Log4j features, e.g., xref:manual/lookups.adoc#DockerLookup[Docker Lookup].
+See xref:manual/lookups.adoc#DockerLookup[Docker Lookup].

Review Comment:
   Fixed in https://github.com/apache/logging-log4j2/pull/2806/commits/225da92980b6217a781af424b3d4757ed184188f



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org