You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/02/27 17:32:59 UTC
[native-toolchain-CR] Test built Python
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19549
Change subject: Test built Python
......................................................................
Test built Python
Resolving 'python' via PATH in the build environment invokes the system
python, not the python we build. Updates the python build to invoke the
binary we built. Also updates the thrift test to do the same using
variables that have already been defined for consistency.
Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
---
M source/python/build.sh
M source/thrift/build.sh
2 files changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/49/19549/1
--
To view, visit http://gerrit.cloudera.org:8080/19549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Gerrit-Change-Number: 19549
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] Test built Python
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19549
to look at the new patch set (#2).
Change subject: Test built Python
......................................................................
Test built Python
Resolving 'python' via PATH in the build environment invokes the system
python, not the python we build. Updates the python build to invoke the
binary we built. Also updates the thrift test to do the same using
variables that have already been defined for consistency.
Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
---
M source/python/build.sh
M source/thrift/build.sh
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/49/19549/2
--
To view, visit http://gerrit.cloudera.org:8080/19549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Gerrit-Change-Number: 19549
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] Test built Python
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19549 )
Change subject: Test built Python
......................................................................
Patch Set 1:
(1 comment)
This doesn't affect the
http://gerrit.cloudera.org:8080/#/c/19549/1/source/python/build.sh
File source/python/build.sh:
http://gerrit.cloudera.org:8080/#/c/19549/1/source/python/build.sh@61
PS1, Line 61: wrap $LOCAL_INSTALL/bin/python -c 'from urllib.request import HTTPSHandler; from http.client import HTTPConnection'
Test build failed because this assumes a python binary when python3 doesn't include one. I'll fix that up.
--
To view, visit http://gerrit.cloudera.org:8080/19549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Gerrit-Change-Number: 19549
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 17:23:10 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Test built Python
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19549 )
Change subject: Test built Python
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19549/1/source/python/build.sh
File source/python/build.sh:
http://gerrit.cloudera.org:8080/#/c/19549/1/source/python/build.sh@61
PS1, Line 61: fi
> Test build failed because this assumes a python binary when python3 doesn't
Done
--
To view, visit http://gerrit.cloudera.org:8080/19549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Gerrit-Change-Number: 19549
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 19:47:55 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Test built Python
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19549 )
Change subject: Test built Python
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Gerrit-Change-Number: 19549
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 17:36:40 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Test built Python
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19549 )
Change subject: Test built Python
......................................................................
Patch Set 2:
I was able to produce a successful build (251-ba99c25016).
--
To view, visit http://gerrit.cloudera.org:8080/19549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Gerrit-Change-Number: 19549
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 19:45:34 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Test built Python
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19549 )
Change subject: Test built Python
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Gerrit-Change-Number: 19549
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Feb 2023 15:37:34 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Test built Python
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19549 )
Change subject: Test built Python
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Gerrit-Change-Number: 19549
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 13:06:47 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Test built Python
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19549 )
Change subject: Test built Python
......................................................................
Test built Python
Resolving 'python' via PATH in the build environment invokes the system
python, not the python we build. Updates the python build to invoke the
binary we built. Also updates the thrift test to do the same using
variables that have already been defined for consistency.
Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Reviewed-on: http://gerrit.cloudera.org:8080/19549
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M source/python/build.sh
M source/thrift/build.sh
2 files changed, 9 insertions(+), 5 deletions(-)
Approvals:
Laszlo Gaal: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2593d6fbe9bd04604507947b85042ff262cfba8
Gerrit-Change-Number: 19549
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>