[GitHub] eolivelli commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing

[gi...@git.apache.org]

eolivelli commented on issue #221: TestAuth#testCloseMethodCalledOnAuthProvider is failing 
URL: https://github.com/apache/bookkeeper/issues/221#issuecomment-312219589
 
 
   @reddycharan @sijie the close method of the factory is expected to be called once.
   I am OK with the fact that close methods should be idempotent too but if it is possible it is better to make the call to "close" once. It is cleaner and for the long term it is the best approch
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services