[GitHub] [incubator-druid] sashidhar commented on issue #8614: The same storage location can be picked up over again with RoundRobinStorageLocationSelectorStrategy

[GitBox <gi...@apache.org>]

sashidhar commented on issue #8614: The same storage location can be picked up over again with RoundRobinStorageLocationSelectorStrategy
URL: https://github.com/apache/incubator-druid/issues/8614#issuecomment-537327355
 
 
   > A potential alternate could be the one explained [here](https://github.com/apache/incubator-druid/pull/8038#discussion_r329008898). The iterators returned by `RoundRobinStorageLocationSelectorStrategy.getLocations()` doesn't share the iteration state. Instead, they start with a different `startIndex` which is changed in a round robin fashion whenever `RoundRobinStorageLocationSelectorStrategy.getLocations()` is called.
   
   Thanks a lot @jihoonson for catching this. The alternate you have suggested fixes this issue. However one caveat is when there is only a single thread loading segments it takes a different `startIndex` after each iteration and the overall order of picking the locations (assuming no location is broken) will not be truly round robin as mentioned in https://github.com/apache/incubator-druid/pull/8038#discussion_r328927992. However I don't have any alternative approach at this moment. If this behaviour with a single thread is okay I'll go ahead and fix as per your suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org