[GitHub] [incubator-devlake-helm-chart] IronCore864 commented on issue #120: Proposal to manage Grafana chart as dependency

["IronCore864 (via GitHub)" <gi...@apache.org>]

IronCore864 commented on issue #120:
URL: https://github.com/apache/incubator-devlake-helm-chart/issues/120#issuecomment-1573642213

   I did some research, and I want to support this proposal. Below are my detailed proposal; requesting for comments:
   
   ---
   
   ## 1 Background
   
   The current situation:
   
   - DevLake supports both Docker compose, and Helm install
   - self-created Grafana Docker image with customized dashboard/datasource definition
   - Grafana Docker image releases together with DevLake, the Grafana version isn't the latest and can't be specified
   - DevLake Helm chart defines a customized Grafana Deployment/Service/Ingress/ConfigMap
   
   ## 2 Proposal
   
   Disconnect DevLake with Grafana. By "disconnect", I mean:
   
   - remove the `grafana` folder from `apache/incubator-devlake` helm chart
   - move the customized dashboard/datasource definition to the `apache/incubator-devlake-helm-chart` repo
   - remove Grafana related K8s manifests from `apache/incubator-devlake-helm-chart`
   - use the official Grafana helm chart as a dependency for the DevLake helm chart
   
   ## 3 Pros and Cons
   
   - reduce DevLake Helm chart complexity
   - no reinventing wheels
   - customize Grafana version
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org