[jira] [Commented] (SAMZA-1852) Clean up TestRunner APIs to auto-generate configs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622880#comment-16622880 ] 

ASF GitHub Bot commented on SAMZA-1852:
---------------------------------------

GitHub user Sanil15 opened a pull request:

    https://github.com/apache/samza/pull/651

    SAMZA-1852 Adding default job system in TestRunner, disabling host affinity to support TableDescriptors and refining addConfig method for TestRunner API           

    - The default system is a required config for intermediate streams, and since no user will write assertions against them, defaulting it makes it easier for the user to write test
    - To support stateful jobs using Table API descriptors we need to disable host affinity, which is enabled by table API by default 
    - @vjagadish pointed out addConfigs vs addOverrideConfig to be a confusing user-facing API. We now support only addConfig with different signatures, this configs takes precedence over any descriptor or TestRunner generated configs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Sanil15/samza SAMZA-1852

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #651
    
----
commit 5bbacddbcad86d28f29e093cf0873fe05d82918a
Author: Sanil15 <sa...@...>
Date:   2018-09-20T23:33:52Z

    Adding default job system in TestRunner, disabling hostaffinity to support TableDescriptors and refining addConfig method for TestRunner API

----


> Clean up TestRunner APIs to auto-generate configs
> -------------------------------------------------
>
>                 Key: SAMZA-1852
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1852
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Jagadish
>            Assignee: Sanil Jain
>            Priority: Major
>
> * Any reason why users have to understand job.default.system when writing a test? Can the framework auto-default it?    
> * Do we need both methods addConfig vs addOverrideConfig in the TestRunner API



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)