You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/07 02:57:10 UTC

[GitHub] [incubator-devlake] lshmouse opened a new pull request, #2987: feat: 🎸 Support BasicAuth configs in devlake helm charts

lshmouse opened a new pull request, #2987:
URL: https://github.com/apache/incubator-devlake/pull/2987

   
   
   ### ⚠️ Pre Checklist
   
   
   # Summary
   
   Add configs: ui.admin.enabled/user/password to enable BasicAuth of config ui in helm charts
   
   ### Does this close any open issues?
   Closes xx
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh commented on a diff in pull request #2987: feat: Support BasicAuth configs in devlake helm charts

Posted by GitBox <gi...@apache.org>.

klesh commented on code in PR #2987:
URL: https://github.com/apache/incubator-devlake/pull/2987#discussion_r964570914


##########
deployment/helm/values.yaml:
##########
@@ -118,6 +118,10 @@ ui:
 
   affinity: {}
 
+  admin:

Review Comment:
   Looks like `basicAuth` would be a more appropriate name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh merged pull request #2987: feat: Support BasicAuth configs in devlake helm charts

Posted by GitBox <gi...@apache.org>.

klesh merged PR #2987:
URL: https://github.com/apache/incubator-devlake/pull/2987


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org