You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "100pah (via GitHub)" <gi...@apache.org> on 2025/07/15 09:18:56 UTC
[PR] Fix/label layout margin [echarts]
100pah opened a new pull request, #21103:
URL: https://github.com/apache/echarts/pull/21103
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
**Most of the changes are renaming.**
Require zrender https://github.com/ecomfe/zrender/pull/1134
### What does this PR do?
+ Clarify some of the uniformly use label layout API and data structure.
+ Fix that some label props were not updated during layout (bug-prone) in certain places.
+ Use uniform label helpers on pie label layout.
+ After that, all of the `minMargin` and `textMargin` process are uniformed, both in impl and doc.
+ Fix the inconsistent behavior in pie label layout.
+ Previously calling `getBoundingRect` before textConfig applied (causing the result diff).
+ Previously adding extra margin for "auto text stroke" even if no auto text stroke added. Currently use https://github.com/ecomfe/zrender/pull/1134 to uniform the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] Fix/label layout margin [echarts]
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia merged PR #21103:
URL: https://github.com/apache/echarts/pull/21103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] Fix/label layout margin [echarts]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21103:
URL: https://github.com/apache/echarts/pull/21103#issuecomment-3072866175
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21103@8901f77
<!-- ECHARTS_PR_PREVIEW -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org