You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "gongycn (via GitHub)" <gi...@apache.org> on 2024/07/29 14:07:26 UTC
[PR] bugfix: fix readonly branch commit errors in Oracle XA transactions. [incubator-seata]
gongycn opened a new pull request, #6707:
URL: https://github.com/apache/incubator-seata/pull/6707
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
fix the issue of readonly branch commit errors in Oracle XA transactions, which leads to long-running transactions being unable to commit and causing unreadable states.
Solution Logic:
When the database is Oracle and the prepare result is XA_RDONLY, notify TC that the current branch status is BranchStatus.PhaseOne_RDONLY (a newly added state to address this issue). During global commit, for branches with this status type, delete the branch log directly and ignore it.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #6512
Original pull request: #6629
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
Based on the problematic local project instance, the verification includes:
Whether the Seata TC frontend displays normally;
In Seata TM managing multiple RMs, whether it functions correctly when there is one or more readonly branches; whether it functions correctly when there are no readonly branches; and whether it functions correctly when there are only one or more readonly branches.
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix readonly branch commit errors in Oracle XA transactions. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6707:
URL: https://github.com/apache/incubator-seata/pull/6707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix readonly branch commit errors in Oracle XA transactions. [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6707:
URL: https://github.com/apache/incubator-seata/pull/6707#discussion_r1695344506
##########
console/src/main/resources/static/js/main.js:
##########
Review Comment:
389 additions, 0 deletions not shown because the diff is too large. Please use a local Git client to view these changes.
What's happening?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix readonly branch commit errors in Oracle XA transactions. [incubator-seata]
Posted by "gongycn (via GitHub)" <gi...@apache.org>.
gongycn commented on code in PR #6707:
URL: https://github.com/apache/incubator-seata/pull/6707#discussion_r1695427423
##########
console/src/main/resources/static/js/main.js:
##########
Review Comment:
@funky-eyes Since the compiled result files like `main.js` have already been removed in pull request #6687, the `main.js` file is also removed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix readonly branch commit errors in Oracle XA transactions. [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #6707:
URL: https://github.com/apache/incubator-seata/pull/6707#issuecomment-2256137666
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6707?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `33.33333%` with `6 lines` in your changes missing coverage. Please review.
> Project coverage is 50.46%. Comparing base [(`7d3cf99`)](https://app.codecov.io/gh/apache/incubator-seata/commit/7d3cf99caea7ce46e77d9248827d0fde5537551e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`78b81ea`)](https://app.codecov.io/gh/apache/incubator-seata/commit/78b81ea128bb09085dec5404a112df5bc0ba004e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6707?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6707 +/- ##
============================================
- Coverage 50.47% 50.46% -0.01%
+ Complexity 5831 5830 -1
============================================
Files 1051 1051
Lines 36340 36347 +7
Branches 4319 4325 +6
============================================
Hits 18342 18342
- Misses 16183 16187 +4
- Partials 1815 1818 +3
```
| [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6707?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/seata/core/model/BranchStatus.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6707?src=pr&el=tree&filepath=core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcore%2Fmodel%2FBranchStatus.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9tb2RlbC9CcmFuY2hTdGF0dXMuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ache/seata/rm/datasource/xa/ConnectionProxyXA.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6707?src=pr&el=tree&filepath=rm-datasource%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Frm%2Fdatasource%2Fxa%2FConnectionProxyXA.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvcm0vZGF0YXNvdXJjZS94YS9Db25uZWN0aW9uUHJveHlYQS5qYXZh) | `55.68% <33.33%> (-0.68%)` | :arrow_down: |
| [...g/apache/seata/server/coordinator/DefaultCore.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6707?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fserver%2Fcoordinator%2FDefaultCore.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9zZXJ2ZXIvY29vcmRpbmF0b3IvRGVmYXVsdENvcmUuamF2YQ==) | `47.15% <0.00%> (-1.10%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6707/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix readonly branch commit errors in Oracle XA transactions. [incubator-seata]
Posted by "gongycn (via GitHub)" <gi...@apache.org>.
gongycn commented on PR #6707:
URL: https://github.com/apache/incubator-seata/pull/6707#issuecomment-2256048175
@funky-eyes Accidentally closed #6629 due to misoperation, resubmitted here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix readonly branch commit errors in Oracle XA transactions. [incubator-seata]
Posted by "gongycn (via GitHub)" <gi...@apache.org>.
gongycn commented on code in PR #6707:
URL: https://github.com/apache/incubator-seata/pull/6707#discussion_r1695427423
##########
console/src/main/resources/static/js/main.js:
##########
Review Comment:
Since the compiled result files like `main.js` have already been removed in pull request #6687, they are also removed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org