You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/23 10:18:14 UTC
[GitHub] [flink] sunjincheng121 commented on a change in pull request #8230:
[FLINK-10977][table] Add streaming non-window FlatAggregate to Table API
sunjincheng121 commented on a change in pull request #8230: [FLINK-10977][table] Add streaming non-window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8230#discussion_r277562778
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/AggregateFunction.java
##########
@@ -100,15 +99,7 @@
* AggregateFunction must be put into the accumulator.
*/
@PublicEvolving
-public abstract class AggregateFunction<T, ACC> extends UserDefinedFunction {
-
- /**
- * Creates and initializes the accumulator for this {@link AggregateFunction}. The accumulator
- * is used to keep the aggregated values which are needed to compute an aggregation result.
- *
- * @return the accumulator with the initial value
- */
- public abstract ACC createAccumulator();
+public abstract class AggregateFunction<T, ACC> extends UserDefinedAggregateFunction<T, ACC> {
Review comment:
`AggregateFunction ` -> `UserDefinedAggregateFunction` line 39.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services