[GitHub] [iceberg] kbendick commented on a change in pull request #2630: [CORE] Enforce tableName is implemented in BaseMetastoreTableOperations for logging

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #2630:
URL: https://github.com/apache/iceberg/pull/2630#discussion_r637849846



##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java
##########
@@ -66,6 +66,11 @@ public NessieTableOperations(
     this.fileIO = fileIO;
   }
 
+  @Override
+  protected String tableName() {
+    return key.toString();

Review comment:
       I took a look and this _seems_ to be derived from the table identifier (via joining the catalog / db name / table parts on `.`).
   
   However, I've not used Nessie as a catalog so please let me know if this is not correct. I will need to test out Nessie some time for my own understanding 🙂 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org