[GitHub] nifi pull request #2034: NIFI-4215 Fixed stackoverflow error when NiFi tries...

[jvwing <gi...@git.apache.org>]

Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2034#discussion_r130225722
  
    --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/avro/AvroTypeUtil.java ---
    @@ -218,6 +218,15 @@ private static Schema nullable(final Schema schema) {
          * @return a Data Type that corresponds to the given Avro Schema
          */
         public static DataType determineDataType(final Schema avroSchema) {
    +        return determineDataType(avroSchema, new HashMap<>());
    +    }
    +
    +    public static DataType determineDataType(final Schema avroSchema, Map<String, DataType> knownRecordTypes) {
    +
    +        if (knownRecordTypes == null) {
    +            throw new IllegalArgumentException("'foundSchemas' cannot be null.");
    --- End diff --
    
    Did you mean this to say "knownRecordTypes" rather than "foundSchemas"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---