You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "akpatnam25 (via GitHub)" <gi...@apache.org> on 2025/09/26 19:03:16 UTC
[PR] [CELEBORN-2162] Supress client side connection error logging [celeborn]
akpatnam25 opened a new pull request, #3491:
URL: https://github.com/apache/celeborn/pull/3491
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Remove some client side connection errors logging that are noisy.
### Why are the changes needed?
see above -- removing noise.
### Does this PR introduce _any_ user-facing change?
yes, removing noisy logs
### How was this patch tested?
ran an app and validated the changes:
```
25/07/23 00:14:08 INFO RegistrationClientBootstrap: authentication initiation started for application_1753182825631_17439_1
25/07/23 00:14:08 INFO RegistrationClientBootstrap: authentication initiation successful for application_1753182825631_17439_1
25/07/23 00:14:08 INFO RegistrationClientBootstrap: Sending SASL message for client authentication
25/07/23 00:14:08 INFO RegistrationClientBootstrap: client authenticated for application_1753182825631_17439_1
25/07/23 00:14:08 INFO TransportClientFactory: Attempted to register with a Master that is not the leader after 73.1 ms: Suggested leader is host3:9097
25/07/23 00:14:08 WARN MasterClient: Connect to host1:9097 failed.
25/07/23 00:14:08 WARN MasterClient: Connect to host2:9097 failed.
25/07/23 00:14:08 INFO RegistrationClientBootstrap: authentication initiation started for application_1753182825631_17439_1
25/07/23 00:14:08 INFO RegistrationClientBootstrap: authentication initiation successful for application_1753182825631_17439_1
25/07/23 00:14:08 INFO RegistrationClientBootstrap: Sending SASL message for client authentication
25/07/23 00:14:08 INFO RegistrationClientBootstrap: client authenticated for application_1753182825631_17439_1
25/07/23 00:14:08 INFO RegistrationClientBootstrap: Registration for application_1753182825631_17439_1
25/07/23 00:14:08 INFO MasterClient: connect to master host3:9097.
25/07/23 00:14:08 INFO MasterClient: connect to master host3:9097.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2162] Supress client side connection error logging [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3491:
URL: https://github.com/apache/celeborn/pull/3491#discussion_r2387076451
##########
common/src/main/java/org/apache/celeborn/common/client/MasterClient.java:
##########
@@ -272,7 +272,7 @@ private RpcEndpointRef setupEndpointRef(String endpoint) {
// Catch all exceptions. Because we don't care whether this exception is IOException or
// TimeoutException or other exceptions, so we just try to connect to host:port, if fail,
// we try next address.
- LOG.warn("Connect to {} failed.", endpoint, e);
+ LOG.info("Connect to {} failed.", endpoint);
Review Comment:
Why does this use INFO level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2162] Supress client side connection error logging [celeborn]
Posted by "akpatnam25 (via GitHub)" <gi...@apache.org>.
akpatnam25 commented on code in PR #3491:
URL: https://github.com/apache/celeborn/pull/3491#discussion_r2396019793
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -350,19 +352,34 @@ public void operationComplete(final Future<Channel> handshakeFuture) {
// Execute any client bootstraps synchronously before marking the Client as successful.
long preBootstrap = System.nanoTime();
logger.debug("Running bootstraps for {} ...", address);
- try {
- for (TransportClientBootstrap clientBootstrap : clientBootstraps) {
+ for (TransportClientBootstrap clientBootstrap : clientBootstraps) {
+ try {
clientBootstrap.doBootstrap(client);
+ } catch (
+ Exception e) { // catch non-RuntimeExceptions too as bootstrap may be written in Scala
+ long bootstrapTime = System.nanoTime() - preBootstrap;
+ if (clientBootstrap instanceof RegistrationClientBootstrap) {
+ Exception processed = RegistrationClientBootstrap.processMasterNotLeaderException(e);
+ String message =
+ (processed instanceof MasterNotLeaderException)
+ ? String.format(
+ "Suggested leader is %s",
+ ((MasterNotLeaderException) processed).getSuggestedLeaderAddress())
+ : e.getMessage();
+ logger.info(
Review Comment:
sure, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2162] Supress client side connection error logging [celeborn]
Posted by "akpatnam25 (via GitHub)" <gi...@apache.org>.
akpatnam25 commented on PR #3491:
URL: https://github.com/apache/celeborn/pull/3491#issuecomment-3340481151
+CC @mridulm @FMX @SteNicholas PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2162] Supress client side connection error logging [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3491: [CELEBORN-2162] Supress client side connection error logging
URL: https://github.com/apache/celeborn/pull/3491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2162] Supress client side connection error logging [celeborn]
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #3491:
URL: https://github.com/apache/celeborn/pull/3491#issuecomment-3377743033
I plan to merge this later this week. +CC @SteNicholas as you reviewed it as well. Thx !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2162] Supress client side connection error logging [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3491:
URL: https://github.com/apache/celeborn/pull/3491#issuecomment-3383813666
@akpatnam25, thanks for update. @mridulm, I have merged into main(v0.7.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2162] Supress client side connection error logging [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3491:
URL: https://github.com/apache/celeborn/pull/3491#discussion_r2387078052
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -350,19 +352,34 @@ public void operationComplete(final Future<Channel> handshakeFuture) {
// Execute any client bootstraps synchronously before marking the Client as successful.
long preBootstrap = System.nanoTime();
logger.debug("Running bootstraps for {} ...", address);
- try {
- for (TransportClientBootstrap clientBootstrap : clientBootstraps) {
+ for (TransportClientBootstrap clientBootstrap : clientBootstraps) {
+ try {
clientBootstrap.doBootstrap(client);
+ } catch (
+ Exception e) { // catch non-RuntimeExceptions too as bootstrap may be written in Scala
+ long bootstrapTime = System.nanoTime() - preBootstrap;
+ if (clientBootstrap instanceof RegistrationClientBootstrap) {
+ Exception processed = RegistrationClientBootstrap.processMasterNotLeaderException(e);
+ String message =
+ (processed instanceof MasterNotLeaderException)
+ ? String.format(
+ "Suggested leader is %s",
+ ((MasterNotLeaderException) processed).getSuggestedLeaderAddress())
+ : e.getMessage();
+ logger.info(
Review Comment:
```suggestion
logger.warn(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2162] Supress client side connection error logging [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3491:
URL: https://github.com/apache/celeborn/pull/3491#discussion_r2387076451
##########
common/src/main/java/org/apache/celeborn/common/client/MasterClient.java:
##########
@@ -272,7 +272,7 @@ private RpcEndpointRef setupEndpointRef(String endpoint) {
// Catch all exceptions. Because we don't care whether this exception is IOException or
// TimeoutException or other exceptions, so we just try to connect to host:port, if fail,
// we try next address.
- LOG.warn("Connect to {} failed.", endpoint, e);
+ LOG.info("Connect to {} failed.", endpoint);
Review Comment:
Why does this use INFO level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org