You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/04 18:35:24 UTC
[GitHub] [incubator-mxnet] ys2843 opened a new pull request #18661: fix broken installation widget - remove empty entries for better UX
ys2843 opened a new pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661
## Description ##
Due to Apache license issue, there was an update to the installation guide on `/get_started` page in #18487 . The new "build from source" guide extracted important instructions of how to build MXNet, however, the removal of many docs left many blank path in installation guide widget. It has a bad UX, because users could click down a configuration path and find nothing useful ( blank content ).
In PR fixes this issue by restructuring the HTML nodes, and removed the empty path so that users will be notified to "build from source" as soon as there is nothing down the path.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
### Changes ###
- [ ] Fixed broken installation widget in master
## Comments ##
- Preview: pending
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661#issuecomment-653998372
> Thanks @ys2843. Do you know which commit broke this? I verified that "please see build from source instructions" showed up correctly before and after merging #18487. So I think there was a later commit that broke the widget, but maybe I'm wrong. Thanks for clarifying
I found other languages except Python don't have `Distribution` option, which contains "build from source" button. So if click down the path to these languages, there isn't a build from source button and the message won't show. But I guess the underlying JavaScript logic is pretty loose that as long as "build from source" button was clicked which set `environ=build-from-source` in URL, the message will always show. So for example if you select build from source under Python and go back to other languages, the message can be seen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661#issuecomment-653798158
@mxnet-label-bot add [Website, pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661#issuecomment-653952274
Thanks @ys2843. Do you know which commit broke this? I verified that this worked correctly before and after merging https://github.com/apache/incubator-mxnet/pull/18487. So I think there was a later commit that broke the widget, but maybe I'm wrong. Thanks for clarifying
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661#issuecomment-653998372
> Thanks @ys2843. Do you know which commit broke this? I verified that "please see build from source instructions" showed up correctly before and after merging #18487. So I think there was a later commit that broke the widget, but maybe I'm wrong. Thanks for clarifying
I found other languages except Python don't have `Distribution` option, which contains "build from source" button. So if click down the path to these languages, there isn't a build from source button and the message won't show. But I guess the underlying JavaScript logic is pretty loose that as long as "build from source" button was clicked which set `environ=build-from-source` in URL, the message will always show.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661#issuecomment-653823420
@mxnet-bot run ci [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661#issuecomment-653798125
Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, sanity, website, centos-gpu, clang, centos-cpu, windows-cpu, unix-gpu, miscellaneous, unix-cpu, windows-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661#issuecomment-653998372
> Thanks @ys2843. Do you know which commit broke this? I verified that "please see build from source instructions" showed up correctly before and after merging #18487. So I think there was a later commit that broke the widget, but maybe I'm wrong. Thanks for clarifying
I found other languages except Python don't have `Distribution` option, which contains "build from source" button. So if click down the path to these languages, there isn't a build from source button and the message won't show. And I guess the underlying JavaScript logic is pretty loose that as long as "build from source" button was clicked which set `environ=build-from-source` in URL, the message will always show.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
leezu edited a comment on pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661#issuecomment-653952274
Thanks @ys2843. Do you know which commit broke this? I verified that "please see build from source instructions" showed up correctly before and after merging https://github.com/apache/incubator-mxnet/pull/18487. So I think there was a later commit that broke the widget, but maybe I'm wrong. Thanks for clarifying
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18661: fix broken installation widget - remove empty entries for better UX
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18661:
URL: https://github.com/apache/incubator-mxnet/pull/18661#issuecomment-653823429
Jenkins CI successfully triggered : [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org