[arrow] branch master updated: ARROW-6112: [C++][Gandiva] Fix TimedTestFilterAdd2

[ra...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ravindra pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 8558e6c  ARROW-6112: [C++][Gandiva] Fix TimedTestFilterAdd2
8558e6c is described below

commit 8558e6cba729e4aff4882e7aa88b5f8a53b63dd0
Author: Chen Li <cn...@fb.com>
AuthorDate: Fri Aug 2 15:25:46 2019 +0530

    ARROW-6112: [C++][Gandiva] Fix TimedTestFilterAdd2
    
    Test should be 'field0 + field1	< field2' based	on
    https://github.com/dremio/gandiva/blob/master/java/src/test/java/org/apache/arrow/gandiva/evaluator/MicroBenchmarkTest.java#L124
    
    Also removed redundant benchmark run.
    
    Closes #4976 from lic9/fix-gandiva-test and squashes the following commits:
    
    77d080d7b <Chen Li>  Fix TimedTestFilterAdd2
    
    Authored-by: Chen Li <cn...@fb.com>
    Signed-off-by: Pindikura Ravindra <ra...@dremio.com>
---
 cpp/src/gandiva/tests/micro_benchmarks.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/cpp/src/gandiva/tests/micro_benchmarks.cc b/cpp/src/gandiva/tests/micro_benchmarks.cc
index e0794a2..6b4dddf 100644
--- a/cpp/src/gandiva/tests/micro_benchmarks.cc
+++ b/cpp/src/gandiva/tests/micro_benchmarks.cc
@@ -139,7 +139,7 @@ static void TimedTestFilterAdd2(benchmark::State& state) {
 
   // Build expression
   auto sum = TreeExprBuilder::MakeFunction(
-      "add", {TreeExprBuilder::MakeField(field1), TreeExprBuilder::MakeField(field2)},
+      "add", {TreeExprBuilder::MakeField(field1), TreeExprBuilder::MakeField(field0)},
       int64());
   auto less_than = TreeExprBuilder::MakeFunction(
       "less_than", {sum, TreeExprBuilder::MakeField(field2)}, boolean());
@@ -392,7 +392,6 @@ static void DecimalAdd3Large(benchmark::State& state) {
 
 BENCHMARK(TimedTestAdd3)->MinTime(1.0)->Unit(benchmark::kMicrosecond);
 BENCHMARK(TimedTestBigNested)->MinTime(1.0)->Unit(benchmark::kMicrosecond);
-BENCHMARK(TimedTestBigNested)->MinTime(1.0)->Unit(benchmark::kMicrosecond);
 BENCHMARK(TimedTestExtractYear)->MinTime(1.0)->Unit(benchmark::kMicrosecond);
 BENCHMARK(TimedTestFilterAdd2)->MinTime(1.0)->Unit(benchmark::kMicrosecond);
 BENCHMARK(TimedTestFilterLike)->MinTime(1.0)->Unit(benchmark::kMicrosecond);