Build improvements/Debugging

[Enrico Olivelli <eo...@gmail.com>]

Hi,
a bunch of issue in current "dev" environment:

1) Surefire trimStackTrace can we set to "false" ?
By default Surefire trims stacktraces, I always set it to "false" but I
have to keep a mofified local pom

2) Protobuf checkStaleness set to "true" ?
This will allow protoc to skip generaing java files at each build and
speeds up the build

3) Problem with maven  compiler plugin
even upgrading to latested and greatest version (3.7.0) it always considers
source files "changed" even while running single tests, this slows down the
build

4) Enabling debug for tests
If there any smarter way to enable debug in tests apart from changing and
not comming log4j.properties ?

I would send a PR for 1) and 2) if you agree
I have no idea about how to fix 3) I will dig into the problem, but
actually solving 3) needs 2)

Thoughts ?
Enrico

Re: Build improvements/Debugging

[Enrico Olivelli <eo...@gmail.com>]

2017-10-19 17:45 GMT+02:00 Ivan Kelly <iv...@apache.org>:

> >> > 4) Enabling debug for tests
> >> > If there any smarter way to enable debug in tests apart from changing
> and
> >> > not comming log4j.properties ?
> >> Why not just enable DEBUG by default, and exclude the overly noisy
> >> stuff like zookeeper?
> > mmm,
> > writing a log of debug will slow up tests and may hide "race conditions"
> by
> > slowing down the execution of methods.
> > writing to the logs introduces "implicit" synchronization
> Another option is to add a profile in maven, which adds a system
> properties to control rootLogger. We should probably strip some stuff
> from the log4j properties too. ROLLINGFILE & TRACEFILE are never used,
> just came in the copy-paste.
>


This will work for me.
I wonder how other guys are working on BookKeeper code....

I will dig into compiler plugin and then create an issue a  patch on main
pom.xml





>
> -Ivan
>

Re: Build improvements/Debugging

[Ivan Kelly <iv...@apache.org>]

>> > 4) Enabling debug for tests
>> > If there any smarter way to enable debug in tests apart from changing and
>> > not comming log4j.properties ?
>> Why not just enable DEBUG by default, and exclude the overly noisy
>> stuff like zookeeper?
> mmm,
> writing a log of debug will slow up tests and may hide "race conditions" by
> slowing down the execution of methods.
> writing to the logs introduces "implicit" synchronization
Another option is to add a profile in maven, which adds a system
properties to control rootLogger. We should probably strip some stuff
from the log4j properties too. ROLLINGFILE & TRACEFILE are never used,
just came in the copy-paste.

-Ivan

Re: Build improvements/Debugging

[Enrico Olivelli <eo...@gmail.com>]

2017-10-19 17:28 GMT+02:00 Ivan Kelly <iv...@apache.org>:

> inline.
>
> > 1) Surefire trimStackTrace can we set to "false" ?
> +1
>
> > 2) Protobuf checkStaleness set to "true" ?
> +1
>
> > 3) Problem with maven  compiler plugin
> > even upgrading to latested and greatest version (3.7.0) it always
> considers
> > source files "changed" even while running single tests, this slows down
> the
> > build
> What has changed? Are they actually building a dependency tree for imports?
>

I have to dig into this, maybe debugging the plugin. For test classes it
does not always recompile the full set of files


> > 4) Enabling debug for tests
> > If there any smarter way to enable debug in tests apart from changing and
> > not comming log4j.properties ?
> Why not just enable DEBUG by default, and exclude the overly noisy
> stuff like zookeeper?
>

mmm,
writing a log of debug will slow up tests and may hide "race conditions" by
slowing down the execution of methods.
writing to the logs introduces "implicit" synchronization


>
> -Ivan
>

Re: Build improvements/Debugging

[Ivan Kelly <iv...@apache.org>]

inline.

> 1) Surefire trimStackTrace can we set to "false" ?
+1

> 2) Protobuf checkStaleness set to "true" ?
+1

> 3) Problem with maven  compiler plugin
> even upgrading to latested and greatest version (3.7.0) it always considers
> source files "changed" even while running single tests, this slows down the
> build
What has changed? Are they actually building a dependency tree for imports?

> 4) Enabling debug for tests
> If there any smarter way to enable debug in tests apart from changing and
> not comming log4j.properties ?
Why not just enable DEBUG by default, and exclude the overly noisy
stuff like zookeeper?

-Ivan