[jira] [Created] (IMPALA-7121) Clean up partitionIds_ member from HdfsTable

["Gabor Kaszab (JIRA)" <ji...@apache.org>]

Gabor Kaszab created IMPALA-7121:
------------------------------------

             Summary: Clean up partitionIds_ member from HdfsTable
                 Key: IMPALA-7121
                 URL: https://issues.apache.org/jira/browse/IMPALA-7121
             Project: IMPALA
          Issue Type: Improvement
          Components: Catalog
    Affects Versions: Impala 2.12.0
            Reporter: Gabor Kaszab


HdfsTable already has a number of internal structures that meant to speed-up processes like partition pruning. partitionIds_ is a HashSet of partition IDs but apparently we already have this information in partitionMap_ that is a mapping between partition IDs and HdfsPartitions. As a result we can simply drop partitionsIds_ and modify getPartitionIds() to return partitionMap_.keySet().

This is not expected to introduce regression for the following reasons:
 * HashMap.keySet() is O(1) complex as it returns a wrapper around an internal set of keys from the HashMap.
 * We have to be careful not to modify this keySet() returned from getPartitionIds() because that would also alter the partitionMap_ member. This is safe as all callsites of getPartitionIds() immediately copies the items of the set to a separate set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org