You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@santuario.apache.org by GitBox <gi...@apache.org> on 2022/07/07 10:46:51 UTC
[GitHub] [santuario-xml-security-java] isaacjensen opened a new pull request, #69: adding RNG specified via system property
isaacjensen opened a new pull request, #69:
URL: https://github.com/apache/santuario-xml-security-java/pull/69
Should allow ability to specify a JAVA_OPT for RNG alg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] seanjmullan commented on pull request #69: adding RNG specified via system property
Posted by GitBox <gi...@apache.org>.
seanjmullan commented on PR #69:
URL: https://github.com/apache/santuario-xml-security-java/pull/69#issuecomment-1176319862
For other system properties, we typically prefix them with the package hierarchy to avoid name clashes, so I would recommend:
`org.apache.xml.security.securerandom.algorithm`
Otherwise, this fix looks ok to me, but I think @coheigea should give the approval since this is in the stax implementation.
On a related issue though, I think we should not hard-code "SHA1PRNG" as the default. There are better alternatives in the JDK now. I would replace this with a call to `new SecureRandom()` or possibly `SecureRandom.getInstanceStrong()`. I haven't looked at the usage to see which is more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] isaacjensen closed pull request #69: adding RNG specified via system property
Posted by GitBox <gi...@apache.org>.
isaacjensen closed pull request #69: adding RNG specified via system property
URL: https://github.com/apache/santuario-xml-security-java/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] isaacjensen commented on pull request #69: adding RNG specified via system property
Posted by GitBox <gi...@apache.org>.
isaacjensen commented on PR #69:
URL: https://github.com/apache/santuario-xml-security-java/pull/69#issuecomment-1176838905
Thanks for the comments @seanjmullan. Let's see if we can get @coheigea approval on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] isaacjensen commented on pull request #69: adding RNG specified via system property
Posted by GitBox <gi...@apache.org>.
isaacjensen commented on PR #69:
URL: https://github.com/apache/santuario-xml-security-java/pull/69#issuecomment-1177388595
@coheigea PR opened against master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] coheigea closed pull request #69: adding RNG specified via system property
Posted by GitBox <gi...@apache.org>.
coheigea closed pull request #69: adding RNG specified via system property
URL: https://github.com/apache/santuario-xml-security-java/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [santuario-xml-security-java] isaacjensen commented on pull request #69: adding RNG specified via system property
Posted by GitBox <gi...@apache.org>.
isaacjensen commented on PR #69:
URL: https://github.com/apache/santuario-xml-security-java/pull/69#issuecomment-1169268323
We run xmlsec 2.1.6 with this patch locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org