You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "Robert Burrell Donkin (JIRA)" <ji...@apache.org> on 2008/05/14 22:32:55 UTC
[jira] Created: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
[GOOGLE-4] Run against compressed artifacts
-------------------------------------------
Key: RAT-17
URL: https://issues.apache.org/jira/browse/RAT-17
Project: RAT
Issue Type: Improvement
Reporter: Robert Burrell Donkin
<blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
Automatically unpack release artifacts (and give hints on directory layout)
</blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798285#action_12798285 ]
Gavin commented on RAT-17:
--------------------------
Hyrum, Can this one be closed now?
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-17-tests.patch, rat-multi-archive.patch, rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (RAT-17) [GOOGLE-4] Run against compressed artifacts
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gavin closed RAT-17.
--------------------
Resolution: Fixed
Assignee: (was: Gavin)
Done
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Attachments: rat-17-tests.patch, rat-multi-archive.patch, rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789844#action_12789844 ]
Gavin commented on RAT-17:
--------------------------
Committed, thanks, let me know how it goes.
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-17-tests.patch, rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789817#action_12789817 ]
Gavin commented on RAT-17:
--------------------------
Thanks, Patched applied. I moved those two documents to the then non-existent 'walker' directory. I had a little trouble applying the patch as your patch seemed to include deletions of the files I was asked to move. Hopefully after a bit of juggling around I've applied it cleanly. Please test and report back if all is well.
Thanks for the patch!
Gav...
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Robert Burrell Donkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Burrell Donkin updated RAT-17:
-------------------------------------
Component/s: engine
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Hyrum Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hyrum Wright updated RAT-17:
----------------------------
Attachment: rat-17-tests.patch
Fixes test failures introduced by recent refactoring done in RAT.
You may need to manually create apache-rat-core/src/test/java/org/apache/rat/walker/ and 'svn mv apache-rat-core/src/test/java/org/apache/rat/FileNameComparatorTest.java apache-rat-core/src/test/java/org/apache/rat/walker/FileNameComparatorTest.java' before applying this patch.
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-17-tests.patch, rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Hyrum Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hyrum Wright updated RAT-17:
----------------------------
Attachment: rat-tar-gz-v2.patch
Per Stefan's suggestions, I'm attaching an updated patch which uses commons-compress to read from the tarball.
Also, before applying the patch, it may be useful to manually 'svn mv' apache-rat-core/src/main/java/org/apache/rat/FileNameComparator.java to apache-rat-core/src/main/java/org/apache/rat/walker/FileNameComparator.java and apache-rat-core/src/main/java/org/apache/rat/DirectoryWalker.java to apache-rat-core/src/main/java/org/apache/rat/walker/DirectoryWalker.java. The patch diff only contains the differences between the moved files and the results.
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Attachments: rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Hyrum Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hyrum Wright updated RAT-17:
----------------------------
Attachment: rat-multi-archive.patch
Aside from some tree conflicts weirdness with Subversion when updating my patched working copy, everything looks good.
This new patch enables support for multiple archive formats, adding .zip and .tar.bz2 to the already-supported .tar.gz. It renames the GZIPWalker class to ArchiveWalker, so you'll probably need to do the associated file move manually before applying the patch.
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-17-tests.patch, rat-multi-archive.patch, rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789851#action_12789851 ]
Gavin commented on RAT-17:
--------------------------
Ok thanks. The 'wierdness' I think is due to files being moved around and worked on. I have been svn mv'ing them my end first before applying them, however your patches include diffs of the files in their original location as well as the moved location. I deleted the diff of the original location before applying this latest patch and all seemed to work well with no conflict wierdness reported my end.
Thanks again.
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-17-tests.patch, rat-multi-archive.patch, rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on RAT-17 started by Gavin.
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-17-tests.patch, rat-multi-archive.patch, rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Hyrum Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789843#action_12789843 ]
Hyrum Wright commented on RAT-17:
---------------------------------
Just added another patch which fixes the test failures caused by recent refactoring associated with the previous patch(es). After this gets committed and I verify that everything is working as expected, I'll submit the patch which allows operation on additional archive types.
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-17-tests.patch, rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Hyrum Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798913#action_12798913 ]
Hyrum Wright commented on RAT-17:
---------------------------------
Yes, I think so. The issue of sorting the output of the various compressed archives can be handled separately.
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-17-tests.patch, rat-multi-archive.patch, rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gavin reassigned RAT-17:
------------------------
Assignee: Gavin
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Assignee: Gavin
> Attachments: rat-tar-gz-v2.patch, rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (RAT-17) [GOOGLE-4] Run against compressed
artifacts
Posted by "Hyrum Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAT-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hyrum Wright updated RAT-17:
----------------------------
Attachment: rat-tar-gz.patch
In using RAT to check potential Subversion release tarballs, I've bumped into a couple of its, uh, limitations. To that end, I've hacked up the attached patch which fixes the immediate itch of not wanting to have to unpack the tarball before running the tool.
Caveats:
* Reports aren't sorted properly for .tar.gz; standard filesystem targets remain unaffected.
* Needed to add a new dependency (ant) to pick up TarInputStream and friends.
* My maven-fu is *very* limited (read: nonexistent) so I kind of guessed at the build system tweakage which needed to happen for the above. Comments/pointers/tweaks appreciated.
* My Java is a bit rusty, so I may not have done things in the most efficient way.
* I don't know the standard RAT coding conventions, but attempted to follow existing conventions where possible.
Future work:
* Allow running on .zip and .tar.bz2 tarballs. This should be relatively easy.
* Properly sort the output of the report generated by running RAT on tarballs.
Let me know of any feedback you may have, or feel free to just tweak the patch before committing. I plan on implementing the followup patches after this one gets committed.
> [GOOGLE-4] Run against compressed artifacts
> -------------------------------------------
>
> Key: RAT-17
> URL: https://issues.apache.org/jira/browse/RAT-17
> Project: RAT
> Issue Type: Improvement
> Components: engine
> Reporter: Robert Burrell Donkin
> Attachments: rat-tar-gz.patch
>
>
> <blockquote cite='http://code.google.com/p/arat/issues/detail?id=4'>
> Automatically unpack release artifacts (and give hints on directory layout)
> </blockquote>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.